Hardcoded nrunner removal in TestSuite #5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a removal of left over of legacy code. When avocado supported `legacy` and `nrunner` runners we also distinguished between resolver resolution and test load. When the `legacy` runner has been removed, we don't have this issue anymore, because resolvers are only supported implementation of test resolution. Unfortunately, we kept validation of supported runners during the test reference resolution with hardcoded `nrunner`. This is wrong because `nrunner` is a `SuiteRunner` plugin, and it can be replaced by any installed `SuiteRunner`. Reference: avocado-framework#5954 Signed-off-by: Jan Richter <[email protected]>
Hi @pevogam, no it is not deprecated, the suite_runner is selected at different place. This code can be removed, because we had it only for distinguishing between legacy |
pevogam
approved these changes
Jun 12, 2024
harvey0100
approved these changes
Jun 13, 2024
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Oct 8, 2024
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Oct 17, 2024
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Jan 27, 2025
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Jan 29, 2025
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Jan 29, 2025
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Jan 31, 2025
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Jan 31, 2025
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Feb 10, 2025
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Feb 10, 2025
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Feb 12, 2025
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Feb 12, 2025
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
pevogam
added a commit
to intra2net/avocado-i2n
that referenced
this pull request
Feb 15, 2025
This drops our previous workaround which was reported as needed in avocado-framework/avocado#5954 and consequently resolved with the merge of the pull request avocado-framework/avocado#5955
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a removal of left over of legacy code. When avocado supported
legacyandnrunnerrunners we also distinguished between resolver resolution and test load. When thelegacyrunner has been removed, we don't have this issue anymore, because resolvers are only supported implementation of test resolution. Unfortunately, we kept validation of supported runners during the test reference resolution with hardcodednrunner. This is wrong becausenrunneris aSuiteRunnerplugin, and it can be replaced by any installedSuiteRunner.Reference: #5954