TaskStatusService connection lost fix #5860
Conversation
This commit will move establishment of status service connection from post method to its own dedicated method. Thanks to this change, it will be possible to establish connection over again when a problem occurs. Signed-off-by: Jan Richter <[email protected]>
There was a problem hiding this comment.
Hi @richtja,
This looks like a step in the right direction. Besides the typo, the fact that the test is failing on CI needs to be addressed.
While I didn't debug your version of the test, I ported it to a non-asyncio version, and it behaves as expected on CI:
Feel free to use that as inspiration or verbatim.
Thanks!
This commit adds error handling to TaskStatusService. When the connection is lost, it will try to establish a new connection. If the connection is not possible to renew, the task will send warning message about new status and remove TaskStatusService from available services. Reference: avocado-framework#5794 Signed-off-by: Jan Richter <[email protected]> Signed-off-by: Cleber Rosa <[email protected]>
richtja
force-pushed
the
status_server_socket_error
branch
from
1612e29
to
2b23b11
Compare
Hi @clebergnu, thank you very much, it was really helpful. I made a force-push with your version of the test and fixed typos. Please have a look. |
This commit adds error handling to TaskStatusService. When the
connection is lost, it will try to establish a new connection. If the
connection is not possible to renew, the task will send warning message
about new status and remove TaskStatusService from available services.
Reference: #5794
Signed-off-by: Jan Richter [email protected]