Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method _update_zip_extra_attrs optimization #5753

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Method _update_zip_extra_attrs optimization #5753

merged 1 commit into from
Sep 5, 2023

Conversation

faker-king
Copy link

Method _update_zip_extra_attrs optimization:

  1. Remove excess assignments from dst
  2. handle exceptions in adding files

@mr-avocado
Copy link

mr-avocado bot commented Aug 25, 2023

Dear contributor,
Avocado is currently under sprint #103, which is due to release an LTS (Long Term Stability) release.
Please avoid merging changes that do not fall into these categories:

  • Bug fixes
  • Usability Improvements
  • Documentation updates

As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality,
but changes to the existing APIs (including interface and behavior) should be avoided.
These kind of changes should wait until sprint #104.

@faker-king faker-king changed the title Signed-off-by: ut005463 <[email protected]> Method _update_zip_extra_attrs optimization Aug 25, 2023
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @faker-king your changes LGTM, thank you for your contribution. Can you please update your commit message to not have your signature in the title. Something like this:

Method _update_zip_extra_attrs optimization

Signed-off-by: mataotao <[email protected]>

It will be better for future search through commit history. Thank you.

@faker-king
Copy link
Author

faker-king commented Aug 31, 2023

Hi @richtja Thank you for your reminder

@faker-king faker-king closed this Aug 31, 2023
@faker-king faker-king reopened this Aug 31, 2023
@faker-king
Copy link
Author

Hi @richtja, If there are no issues, can this modification be incorporated

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @faker-king, it LGTM now. Thank you.

@richtja richtja merged commit 4bf7543 into avocado-framework:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants