Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avocado lint check is not working on python3.12 #5957

Closed
richtja opened this issue Jun 13, 2024 · 3 comments
Closed

Avocado lint check is not working on python3.12 #5957

richtja opened this issue Jun 13, 2024 · 3 comments
Assignees
Labels

Comments

@richtja
Copy link
Contributor

richtja commented Jun 13, 2024

Describe the bug
When you run ./selftests/lint.sh on python3.12 with dev installation the test will error with astroid.exceptions.AstroidError.

Steps to reproduce
in python3.12 environment:

$ pip install -r requirements-dev.txt
$ python3 -m pip install setuptools
$ python3 setup.py develop --user
$ ./selftests/lint.sh

Expected behavior
The test would pass.

Current behavior

Traceback (most recent call last):
  File "/home/janrichter/.pyenv/versions/avocado_3.12/bin/pylint", line 8, in <module>
    sys.exit(run_pylint())
             ^^^^^^^^^^^^
  File "/home/janrichter/.pyenv/versions/3.12.0/envs/avocado_3.12/lib/python3.12/site-packages/pylint/__init__.py", line 36, in run_pylint
    PylintRun(argv or sys.argv[1:])
  File "/home/janrichter/.pyenv/versions/3.12.0/envs/avocado_3.12/lib/python3.12/site-packages/pylint/lint/run.py", line 215, in __init__
    linter.check(args)
  File "/home/janrichter/.pyenv/versions/3.12.0/envs/avocado_3.12/lib/python3.12/site-packages/pylint/lint/pylinter.py", line 693, in check
    check_parallel(
  File "/home/janrichter/.pyenv/versions/3.12.0/envs/avocado_3.12/lib/python3.12/site-packages/pylint/lint/parallel.py", line 158, in check_parallel
    for (
  File "/home/janrichter/.pyenv/versions/3.12.0/lib/python3.12/concurrent/futures/process.py", line 608, in _chain_from_iterable_of_lists
    for element in iterable:
  File "/home/janrichter/.pyenv/versions/3.12.0/lib/python3.12/concurrent/futures/_base.py", line 619, in result_iterator
    yield _result_or_cancel(fs.pop())
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/janrichter/.pyenv/versions/3.12.0/lib/python3.12/concurrent/futures/_base.py", line 317, in _result_or_cancel
    return fut.result(timeout)
           ^^^^^^^^^^^^^^^^^^^
  File "/home/janrichter/.pyenv/versions/3.12.0/lib/python3.12/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/home/janrichter/.pyenv/versions/3.12.0/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
astroid.exceptions.AstroidError

System information (please complete the following information):

  • OS:
LSB Version:    :core-5.0-amd64:core-5.0-noarch
Distributor ID: Fedora
Description:    Fedora release 39 (Thirty Nine)
Release:        39
Codename:       ThirtyNine

  • Avocado version: mater
  • Avocado installation method: github
@richtja richtja added the bug label Jun 13, 2024
@mr-avocado mr-avocado bot moved this to Triage in Default project Jun 13, 2024
@PaulYuuu
Copy link

pylint==2.17.2 does not support python3.12 I think, and astroid is in the dep-list of pylint.

richtja added a commit to richtja/avocado that referenced this issue Jun 17, 2024
This will update the pylint to version 3.0.0 without enabling any new
checks. This is needed because, the pylint 2.17.2 is not compatible with
python3.12

Reference: avocado-framework#5957
Signed-off-by: Jan Richter <[email protected]>
@richtja richtja self-assigned this Jun 17, 2024
@richtja richtja moved this from Triage to In progress in Default project Jun 17, 2024
@richtja
Copy link
Contributor Author

richtja commented Jun 17, 2024

pylint==2.17.2 does not support python3.12 I think, and astroid is in the dep-list of pylint.

Hi @PaulYuuu, yes, you are right. I have created #5959 to update the pylint to a newer version, which should fix this issue.

richtja added a commit to richtja/avocado that referenced this issue Jul 8, 2024
This will update the pylint to version 3.0.0 without enabling any new
checks. This is needed because, the pylint 2.17.2 is not compatible with
python3.12

Reference: avocado-framework#5957
Signed-off-by: Jan Richter <[email protected]>
richtja added a commit to richtja/avocado that referenced this issue Jul 10, 2024
This will update the pylint to version 3.0.0 without enabling any new
checks. This is needed because, the pylint 2.17.2 is not compatible with
python3.12

Reference: avocado-framework#5957
Signed-off-by: Jan Richter <[email protected]>
richtja added a commit to richtja/avocado-static-checks that referenced this issue Jul 22, 2024
This will update the pylint to version 3.0.0. This is needed because,
the pylint 2.17.2 is not compatible with python3.12

Reference: avocado-framework/avocado#5957
Signed-off-by: Jan Richter <[email protected]>
@richtja
Copy link
Contributor Author

richtja commented Jul 24, 2024

Closing as fixed in #5959

@richtja richtja closed this as completed Jul 24, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done 107 in Default project Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants