Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating organisation with same name not handled #1289

Closed
4 tasks
Tracked by #1641
AchalaBelokar opened this issue Jul 23, 2024 · 14 comments
Closed
4 tasks
Tracked by #1641

Creating organisation with same name not handled #1289

AchalaBelokar opened this issue Jul 23, 2024 · 14 comments
Assignees

Comments

@AchalaBelokar
Copy link

AchalaBelokar commented Jul 23, 2024

Need:

So far 3 times, this issue has been raised by different people. To make our work process smooth.

Describe the bug
Not able to create organisation through super admin on staging
Login with admin and try to create a organisation
it is showing communication error

To Reproduce
Steps to reproduce the behavior:

  1. Login with admin user
  2. Click on organisation
  3. try to create a organisation with the same name as already existing organisation.
  4. See error
Screen.Recording.2024-07-23.at.2.36.50.PM.mov

Expected behaviour

  • Show error message under the Name field stating 'Organisation with the same name already exists. Please try with a different name.'
  • The below common message 'The form is not valid. Please check for errors.' also need to show.
Screenshot 2024-08-05 at 5 59 25 PM
  • The above issue happens for same dbname, schemaname, etc as well - Handle them like the above.
  • Handle other additional validations applicable to db_user also - comment on the same.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Developer Checklist(Developer fixing the bug should fill this checklist)

  • Does the fix require extensive regression testing?
    • Yes
    • No
  • Are you mentioning the required scenarios that could be affected?
    • Yes
    • No
@AchalaBelokar AchalaBelokar added the bug Something isn't working label Jul 23, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Jul 23, 2024
@mahalakshme mahalakshme moved this from New Issues to Ready in Avni Product Jul 23, 2024
@mahalakshme mahalakshme removed the bug Something isn't working label Jul 23, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Jul 23, 2024

@AchalaBelokar please try with another org name. There is already an org with the name 'testbun'

@1t5j0y 1t5j0y moved this from Ready to QA Ready in Avni Product Jul 23, 2024
@mahalakshme
Copy link
Contributor

since it should 've shown a readable error message ll schedule it in a different release

@mahalakshme mahalakshme moved this from QA Ready to In Analysis in Avni Product Jul 23, 2024
@mahalakshme mahalakshme added the good first issue Good for newcomers label Aug 5, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Aug 5, 2024
@mahalakshme mahalakshme changed the title Not able to create organisation through super admin on staging Creating organisation with same name not handled Aug 5, 2024
@mahalakshme mahalakshme moved this from Analysis Complete to Ready in Avni Product Oct 17, 2024
@mahalakshme mahalakshme moved this from Ready to In Analysis in Avni Product Oct 21, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Nov 26, 2024
@mahalakshme mahalakshme removed the good first issue Good for newcomers label Nov 26, 2024
@vedfordev vedfordev self-assigned this Nov 29, 2024
@vedfordev vedfordev moved this from Ready to In Progress in Avni Product Nov 29, 2024
@vedfordev
Copy link
Contributor

vedfordev commented Nov 29, 2024

Tried with CustomToolbar and {handleSubmitWithRedirect,handleSubmit,save} still not working. Seems like older version not support this.

@dinesh2096 dinesh2096 self-assigned this Dec 4, 2024
@dinesh2096 dinesh2096 moved this from In Progress to Code Review Ready in Avni Product Dec 4, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Dec 5, 2024

@vedfordev please share the commit(s) for this issue. Couldn't locate them

@vedfordev
Copy link
Contributor

@vedfordev please share the commit(s) for this issue. Couldn't locate them

@dinesh2096 by mistake moved to review. it is in progress.

@vedfordev vedfordev moved this from Code Review Ready to In Progress in Avni Product Dec 5, 2024
@vedfordev vedfordev moved this from In Progress to Code Review Ready in Avni Product Dec 5, 2024
@mahalakshme
Copy link
Contributor

@vedfordev please find my comment above

@mahalakshme mahalakshme moved this from Hold to QA Failed in Avni Product Dec 20, 2024
@vedfordev vedfordev moved this from QA Failed to In Progress in Avni Product Dec 23, 2024
vedfordev added a commit to avniproject/avni-server that referenced this issue Dec 23, 2024
@vedfordev
Copy link
Contributor

@vedfordev please find my comment above

@dinesh2096 added constraint and notification.

@vedfordev vedfordev moved this from In Progress to In QA in Avni Product Dec 23, 2024
vedfordev added a commit to avniproject/avni-server that referenced this issue Dec 23, 2024
…name suffix and schema

(cherry picked from commit 1901bdf)
vedfordev added a commit that referenced this issue Dec 23, 2024
@vedfordev vedfordev moved this from In QA to In Progress in Avni Product Dec 23, 2024
@vedfordev
Copy link
Contributor

@mahalakshme server migration causing issue due to there are many org with usernamesuffix blank and duplicates.

SELECT username_suffix,count(id)
FROM public.organisation
group by username_suffix
having count(id) > 1
;
-- 24 with null

SELECT schema_name,count(id)
FROM public.organisation
group by schema_name
having count(id) > 1
;


select *
from organisation
where username_suffix is null
;

@mahalakshme
Copy link
Contributor

@vedfordev I will move this back to 'In Analysis'. Will get back on this.

@mahalakshme mahalakshme moved this from In Progress to In Analysis in Avni Product Dec 24, 2024
vedfordev added a commit to avniproject/avni-server that referenced this issue Dec 24, 2024
…for username suffix and schema"

This reverts commit 1901bdf.
@mahalakshme
Copy link
Contributor

@vedfordev we need not add unique constraint for username suffix

@vedfordev
Copy link
Contributor

@vedfordev we need not add unique constraint for username suffix

@dinesh2096 please check this and UI Changes are on branch 10.2

@mahalakshme I reverted the migration change in master Link

@vedfordev vedfordev moved this from In Analysis to QA Ready in Avni Product Dec 24, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Dec 24, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Dec 24, 2024
@dinesh2096 dinesh2096 reopened this Dec 26, 2024
@github-project-automation github-project-automation bot moved this from Done to Triaged in Avni Product Dec 26, 2024
@dinesh2096 dinesh2096 moved this from Triaged to QA Failed in Avni Product Dec 26, 2024
@dinesh2096 dinesh2096 moved this from QA Failed to Done in Avni Product Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

6 participants