[pull] master from SciML:master #31
Open
+17,258
−8,366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Signed-off-by: ErikQQY <[email protected]>
Better BigFloat support
fix: missing Tracker.data
Return InitialFailure from bracketing methods if not enclosing interval
…nearsolve_history
fix: restore the history of SimpleNonlinearSolve
* fix: hessian through nonlinear solvers * feat: extend gradient support for cached nlls
* ci: run windows tests with a single worker * test: try fixing more mac tests * test: div by zero * test: add retries to guard against segfaults
* refactor: Move NonlinearSolvePolyAlgorithm to Base * test: Make NonlinearSolve use 1.3 Base * refactor: Remove unnecessary snippet * refactor: Don't use duplicate solve * refactor: Test Base export NonlinearSolvePolyAlgorithm
…#498) * Fix ambiguity in `__solve` with polyalgorithm due to dispatch on `Val{N}` Noticed downstream ``` Candidates: kwcall(::NamedTuple, ::typeof(SciMLBase.__solve), prob::SciMLBase.AbstractNonlinearProblem, alg::NonlinearSolveBase.NonlinearSolvePolyAlgorithm{Val{N}}, args...) where N @ NonlinearSolveBase ~/.julia/packages/NonlinearSolveBase/54f3T/src/solve.jl:106 kwcall(::NamedTuple, ::typeof(SciMLBase.__solve), prob::Union{SciMLBase.NonlinearLeastSquaresProblem{<:Union{Number, var"#s15"} where var"#s15"<:AbstractArray, iip, <:Union{var"#s14", var"#s13"} where {var"#s14"<:ForwardDiff.Dual{T, V, P}, var"#s13"<:(AbstractArray{<:ForwardDiff.Dual{T, V, P}})}} where {iip, T, V, P}, SciMLBase.NonlinearProblem{<:Union{Number, var"#s15"} where var"#s15"<:AbstractArray, iip, <:Union{var"#s14", var"#s13"} where {var"#s14"<:ForwardDiff.Dual{T, V, P}, var"#s13"<:(AbstractArray{<:ForwardDiff.Dual{T, V, P}})}} where {iip, T, V, P}}, alg::NonlinearSolveBase.AbstractNonlinearSolveAlgorithm, args...) @ NonlinearSolve ~/.julia/packages/NonlinearSolve/LuVnf/src/forward_diff.jl:14 kwcall(::NamedTuple, ::typeof(SciMLBase.__solve), prob::Union{SciMLBase.NonlinearLeastSquaresProblem{<:Union{Number, var"#s15"} where var"#s15"<:AbstractArray, iip, <:Union{var"#s14", var"#s13"} where {var"#s14"<:ForwardDiff.Dual{T, V, P}, var"#s13"<:(AbstractArray{<:ForwardDiff.Dual{T, V, P}})}} where {iip, T, V, P}, SciMLBase.NonlinearProblem{<:Union{Number, var"#s15"} where var"#s15"<:AbstractArray, iip, <:Union{var"#s14", var"#s13"} where {var"#s14"<:ForwardDiff.Dual{T, V, P}, var"#s13"<:(AbstractArray{<:ForwardDiff.Dual{T, V, P}})}} where {iip, T, V, P}}, alg::NonlinearSolveBase.NonlinearSolvePolyAlgorithm, args...) @ NonlinearSolve ~/.julia/packages/NonlinearSolve/LuVnf/src/forward_diff.jl:14 Possible fix, define kwcall(::NamedTuple, ::typeof(SciMLBase.__solve), ::Union{SciMLBase.NonlinearLeastSquaresProblem{<:Union{Number, var"#s15"} where var"#s15"<:AbstractArray, iip, <:Union{var"#s14", var"#s13"} where {var"#s14"<:ForwardDiff.Dual{T, V, P}, var"#s13"<:(AbstractArray{<:ForwardDiff.Dual{T, V, P}})}} where {iip, T, V, P}, SciMLBase.NonlinearProblem{<:Union{Number, var"#s15"} where var"#s15"<:AbstractArray, iip, <:Union{var"#s14", var"#s13"} where {var"#s14"<:ForwardDiff.Dual{T, V, P}, var"#s13"<:(AbstractArray{<:ForwardDiff.Dual{T, V, P}})}} where {iip, T, V, P}}, ::NonlinearSolveBase.NonlinearSolvePolyAlgorithm{Val{N}}, ::Vararg{Any}) where N ``` https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/11786040241/job/32828542508?pr=2522 The issue is that the polyalgorithm code is dispatching on more details of the polyalgorithm than https://github.com/SciML/NonlinearSolve.jl/blob/master/src/forward_diff.jl#L13-L25 which leads to an ambiguity. But it only needs that information since it's a generated function. The easy fix is to just make the generated function be one step lower. * Update forward_ad_tests.jl * Update lib/NonlinearSolveBase/src/solve.jl
* fix: fix SII implementation for caches * test: fix SII tests * ci: don't fail CI jobs if code coverage reporting fails --------- Co-authored-by: Anant Thazhemadam <[email protected]>
* Create SCCNonlinearSolve * Update lib/SCCNonlinearSolve/src/SCCNonlinearSolve.jl Co-authored-by: Aayush Sabharwal <[email protected]> * Update lib/SCCNonlinearSolve/src/SCCNonlinearSolve.jl Co-authored-by: Aayush Sabharwal <[email protected]> * Update lib/SCCNonlinearSolve/src/SCCNonlinearSolve.jl Co-authored-by: Aayush Sabharwal <[email protected]> * Update lib/SCCNonlinearSolve/test/core_tests.jl Co-authored-by: Aayush Sabharwal <[email protected]> * format scc * just use params * re format * SII * fix CI * Update lib/SCCNonlinearSolve/src/SCCNonlinearSolve.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix up test setup * Update Project.toml * Update core_tests.jl * Update lib/SCCNonlinearSolve/test/core_tests.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update lib/SCCNonlinearSolve/test/core_tests.jl * Update core_tests.jl * Update lib/SCCNonlinearSolve/test/core_tests.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update core_tests.jl * Update Project.toml * Update lib/SCCNonlinearSolve/test/qa_tests.jl * Update lib/SCCNonlinearSolve/test/qa_tests.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update Project.toml * Update qa_tests.jl * Update lib/SCCNonlinearSolve/test/qa_tests.jl * Update lib/SCCNonlinearSolve/test/qa_tests.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Aayush Sabharwal <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: Move RobustMultiNewton to NonlinearSolveFirstOrder * refactor: Implicit import NonlinearSolvePolyAlgorithm
Co-authored-by: Christopher Rackauckas <[email protected]>
* Update release_notes.md * Update docs/src/release_notes.md
* fix: remove compiled reversediff from default options * fix: enzyme is now properly supported in 1.11
* feat: add `get_abstol` and `get_reltol` interface methods * feat: add `initialize_cache!` * feat: implement initialization for polyalg cache * feat: implement initialization for no-init cache * feat: implement initialization for first order cache * feat: implement initialization for `QuasiNewtonCache` * feat: implement initialization for `GeneralizedDFSaneCache` * fix: fix `SII.parameter_values` * feat: implement initialization for `SimpleNonlinearSolve` * fix: fix `InternalAPI.reinit_self!` for `GeneralizedDFSaneCache` * fix: fix `SII.state_values` for `NoInitCache` * feat: run initialiation on `solve!` * build: bump SciMLBase compat in NonlinearSolveBase
* build: bump versions of `NonlinearSolve` and sub-packages * build: bump compats between sub-packages
* Fix incorrect Base version and bump * Update Project.toml --------- Co-authored-by: Christopher Rackauckas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )