Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Address golangci issues and introduce goimports #99

Merged
merged 1 commit into from
May 3, 2023

Conversation

draftcode
Copy link
Contributor

  • Address io/ioutil deprecation. Replace it with os and io equivalents.
  • Add goimports as import statements flips occasionally
  • Replace deprecated structcheck with unused
  • Run gofmt for all

@aviator-app
Copy link
Contributor

aviator-app bot commented May 2, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

@draftcode draftcode requested a review from twavv May 2, 2023 22:06
Copy link
Contributor

@twavv twavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add pre-commit hooks?

* Address io/ioutil deprecation. Replace it with os and io equivalents.
* Add goimports as import statements flips occasionally
* Replace deprecated structcheck with unused
* Run gofmt for all
@draftcode
Copy link
Contributor Author

Should we add pre-commit hooks?

Maybe later.

@aviator-app aviator-app bot merged commit 442e6ec into master May 3, 2023
@aviator-app aviator-app bot deleted the goimports branch May 3, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants