feat: [MER-1493] show up to date info about branches in stack tree #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator. |
draftcode
reviewed
May 2, 2023
draftcode
requested changes
May 2, 2023
doratzeng
commented
May 2, 2023
| // Check if branch is up to date with the upstream branch. | ||
| // This is doing `git diff <givenBranch> remotes/origin/<givenBranch>` | ||
| func getUpstreamStatus(repo *git.Repo, branch meta.Branch) (string, error) { | ||
| upstreamExists, err := repo.DoesRemoteBranchExist(branch.Name) |
There was a problem hiding this comment.
note that this only checks the local reference for if the upstream branch exists. also if the branch has already been merged and deleted, we will not display the not pushed messaged.
discussed offline with @draftcode , I think this should be ok for now.
draftcode
reviewed
May 3, 2023
draftcode
requested changes
May 8, 2023
draftcode
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the following info about each branch for
av stack tree(will probably need some UI improvements)