feat: Add av stack tidy #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command is used to update the av-cli's internal branch metadata based on the Git branches to some extent. The expected usage is that after a branch is merged or deleted, run this command to synchronize the internal metadata. Probably we can do more magic and hide the details on the branch metadata furthermore, and automatically tidies up in av stack sync. That can be done in the future. Right now, unable to delete a branch is critical, and this should act as a stop-gap solution.
Current Aviator status
This PR was merged using Aviator. |
twavv
approved these changes
Apr 17, 2023
| return err | ||
| } | ||
| branches := make(map[string]*meta.Branch) | ||
| for name, br := range origBranches { |
There was a problem hiding this comment.
I don't think this is strictly necessary. We could just do
for name := range branches {
branches[name].Parent = newParent
}
There was a problem hiding this comment.
If you feel that you'd rather do it this way, that's fine too.
There was a problem hiding this comment.
Nope. You cannot. See https://stackoverflow.com/questions/42605337/cannot-assign-to-struct-field-in-a-map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command is used to update the av-cli's internal branch metadata
based on the Git branches to some extent. The expected usage is that
after a branch is merged or deleted, run this command to synchronize the
internal metadata.
Probably we can do more magic and hide the details on the branch
metadata furthermore, and automatically tidies up in av stack sync. That
can be done in the future. Right now, unable to delete a branch is
critical, and this should act as a stop-gap solution.