Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Construct correct list of branches to be synced during stack sync #62

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

twavv
Copy link
Contributor

@twavv twavv commented Sep 30, 2022

This fixes how we store the list of branches being synced during the current av stack sync. This bug would only manifest if the stack sync was being run from a branch that is not at the end of the stack and the stack sync was interrupted on a branch that comes after the originally checked out branch in the stack.

Confirmed that the new test failed with the code changes and passes now.

This fixes how we store the list of branches being synced during the current `av stack sync`. This bug would only manifest if the stack sync was being run from a branch that is not at the end of the stack and the stack sync was interrupted on a branch that comes after the originally checked out branch in the stack.

Confirmed that the new test failed with the code changes and passes now.
@twavv twavv marked this pull request as ready for review September 30, 2022 17:15
@twavv twavv requested a review from ohcnivek September 30, 2022 17:15
Copy link
Contributor

@ohcnivek ohcnivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice

@aviator-app
Copy link
Contributor

aviator-app bot commented Sep 30, 2022

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@aviator-app aviator-app bot merged commit 2e0c361 into master Sep 30, 2022
@aviator-app aviator-app bot deleted the travis/mer-1349-av-cli-fix-stack-sync-if-run-from branch September 30, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants