feat(stack branch): Support renaming branches #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainankit
reviewed
Aug 5, 2022
| return err | ||
| } | ||
|
|
||
| if !currentMeta.Parent.Trunk { |
There was a problem hiding this comment.
can you add comments describing this part. If I understand this correctly, we are setting the parent to point to the new branch as the child.
jainankit
approved these changes
Aug 5, 2022
Aviator status
This PR was merged using Aviator. |
aviator-app
bot
deleted the
travis/mer-1022-av-cli-support-renaming-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit large because golangci-lint just released a new version (last night I think) that breaks our CI for some reason. I'm not entirely sure, but Go 1.19 introduced a small change to how doc comments are formatted when using
gofmtandgolangci-lintwas complaining (in a rather opaque way) because it... is apparently trying to use that version ofgofmteven though we're on Go 1.18? I couldn't really reproduce it withgolangci-lint, but this change just runs the code from source directly. (Adding these kinds of things totools.gois a pretty common practice and doesn't increase the size of our build executable or anything)If you want to look at just the first commit, that might be easier since it contains all the actual code changes.