Fix the position of the help message in the stack switch view #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator. Stack
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
FlexReview SummaryBased on the code complexity and the author's expertise score, these are the suggested reviewers:
See the list of alternate reviewers in the detailed breakdown below. Detailed BreakdownAuthor’s expertise score for the modified files:
† Indicates that the file doesn't need an expert review. (?) See full breakdown of the reviewers on the Aviator webapp. |
jainankit
approved these changes
Jun 17, 2024
draftcode
force-pushed
the
fix_switch_help
branch
from
baf2730
to
ba805a9
Compare
draftcode
force-pushed
the
stack_branch_branch_rtb
branch
2 times, most recently
from
50ed0b8
to
31edd7d
Compare
draftcode
force-pushed
the
fix_switch_help
branch
2 times, most recently
from
3bd160f
to
407d07d
Compare
draftcode
force-pushed
the
stack_branch_branch_rtb
branch
from
31edd7d
to
93c82c9
Compare
draftcode
force-pushed
the
fix_switch_help
branch
from
407d07d
to
78bb165
Compare
draftcode
force-pushed
the
stack_branch_branch_rtb
branch
from
93c82c9
to
175d2a8
Compare
When creating a new branch from a trunk branch, the stack branch command is better to start off from the remote tracking branch instead of the local branch. This way, the new branch will be created from the latest state of the trunk branch. While we are here, accept `origin/HEAD` as the parent branch name and resolve it to the default branch. Previously, this command automatically "adopts" the parent branch to av automatically, assuming that the parent branch's parent is the default branch, which might not be true. Instead, this command checks if the parent branch is already adopted or not.
draftcode
force-pushed
the
fix_switch_help
branch
from
78bb165
to
76eec9e
Compare
draftcode
force-pushed
the
stack_branch_branch_rtb
branch
from
175d2a8
to
e97fefb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the help line was on the same line as master.