Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for remotes other than origin #340

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

Konboi
Copy link
Contributor

@Konboi Konboi commented Jun 15, 2024

#9

Now av supports only remote origin but I sometimes set multiple remotes and set a name something other than origin

To support it, I added remote and updated to use it

Copy link
Contributor

aviator-app bot commented Jun 15, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

aviator-app bot commented Jun 15, 2024

FlexReview Summary

Based on the code complexity and the author's expertise score, these are the suggested reviewers:

  • @draftcode (current review load: 1)

See the list of alternate reviewers in the detailed breakdown below.

Detailed Breakdown Author’s expertise score for the modified files:
  • cmd/av/commit_common.go (0.00)
  • cmd/av/stack_adopt.go (0.00)
  • cmd/av/stack_reparent.go (0.00)
  • cmd/av/stack_restack.go (0.00)
  • cmd/av/stack_sync.go (0.00)
  • internal/actions/pr.go (0.00)
  • internal/config/config.go (0.00)
  • internal/gh/ghui/fetch.go (0.00)
  • internal/gh/ghui/push.go (0.00)
  • internal/git/git.go (0.00)
  • internal/git/git_test.go (0.00)
  • internal/git/gitui/prune.go (0.00)
Files Reviewers
cmd/av/commit_common.go †,
cmd/av/stack_adopt.go †,
cmd/av/stack_reparent.go †,
cmd/av/stack_restack.go †,
cmd/av/stack_sync.go †,
internal/config/config.go †,
internal/gh/ghui/fetch.go †,
internal/gh/ghui/push.go †,
internal/git/git.go †,
internal/git/git_test.go †,
internal/git/gitui/prune.go
@draftcode (score: 1.00, current review load: 1),
@jainankit (score: 0.74, current review load: 1)

† Indicates that the file doesn't need an expert review. (?)

See full breakdown of the reviewers on the Aviator webapp.

@aviator-app aviator-app bot requested a review from draftcode June 15, 2024 00:18
@@ -108,6 +110,14 @@ func (r *Repo) TrunkBranches() ([]string, error) {
return branches, nil
}

func (r *Repo) GetRemoteName() string {
if config.Av.Remote != "" {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is better, setting it as the initial value (at here) or checking it here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine.

@aviator-app aviator-app bot merged commit d2739d7 into aviator-co:master Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants