Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write messages from UpdatePullRequestState #284

Closed
wants to merge 1 commit into from

Conversation

draftcode
Copy link
Contributor

@draftcode draftcode commented May 14, 2024

We want to use this method in other places. It should not write the
stderr to avoid interference with the output of the caller.

Copy link
Contributor

aviator-app bot commented May 14, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

Stack

  1. 👉 Do not write messages from UpdatePullRequestState #284 👈 (this pr)

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

aviator-app bot commented May 14, 2024

FlexReview Summary

Based on the code complexity and the author's expertise score, these are the suggested reviewers:

  • @jainankit (current review load: 3)

See the list of alternate reviewers in the detailed breakdown below.

Detailed Breakdown Author’s expertise score for the modified files:
  • internal/actions/pr.go (1.00)
  • internal/actions/sync_branch.go (1.00)
Files Reviewers
internal/actions/pr.go †,
internal/actions/sync_branch.go
@jainankit (score: 0.49, current review load: 3),
@doratzeng (score: 0.08, current review load: 1)

† Indicates that the file doesn't need an expert review. (?)

See full breakdown of the reviewers on the Aviator webapp.

@aviator-app aviator-app bot requested a review from jainankit May 14, 2024 23:20
Base automatically changed from remove_unused to master May 16, 2024 17:15
Copy link
Contributor

aviator-app bot commented May 16, 2024

This PR is stacked on top of #283 which was merged. This PR (and its dependents) need to be synchronized on the commit that was merged into master. From your repository, run the following commands:

# Switch to this branch
git checkout extract_messages
# Sync this branch (and its children) on top of the merge commit
av stack sync
# Optionally update pull requests to match new stack
av stack submit

We want to use this method in other places. It should not write the
stderr to avoid interference with the output of the caller.
@aviator-app aviator-app bot closed this in 6488d73 May 17, 2024
@draftcode draftcode deleted the extract_messages branch May 20, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants