Support av stack branch <new branch> <base branch>
#265
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
cmd/av/branch.go
Outdated
| return err | ||
| } | ||
|
|
||
| if _, err := repo.CheckoutBranch(&git.CheckoutBranch{Name: newBranch, NewBranch: true}); err != nil { |
There was a problem hiding this comment.
Do we need to back to the working branch?
With the current implementation, it will checkout a new branch
cmd/av/branch.go
Outdated
| ) | ||
| } | ||
| } | ||
| tx.SetBranch(meta.Branch{ |
There was a problem hiding this comment.
Can we add a new branch to DB?
e2e_tests/branch_test.go
Outdated
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestBranch(t *testing.T) { |
There was a problem hiding this comment.
I'm not sure using the av stack tree command is a good way to test. What do you think? Are there any other good ways??
FlexReview SummaryBased on the code complexity and the author's expertise score, these are the suggested reviewers:
See the list of alternate reviewers in the detailed breakdown below. Detailed BreakdownAuthor’s expertise score for the modified files:
† Indicates that the file doesn't need an expert review. (?) See full breakdown of the reviewers on the Aviator webapp. |
Konboi
changed the title
av branch <new branch> <base branch> command
Konboi
changed the title
av branch <new branch> <base branch> commandav branch <new branch> <base branch> command
Konboi
changed the title
av branch <new branch> <base branch> commandav branch <new branch> <base branch> command
Konboi
changed the title
av branch <new branch> <base branch> commandav branch <new branch> <base branch> command
cmd/av/branch.go
Outdated
| ) | ||
|
|
||
| var branchCmd = &cobra.Command{ | ||
| Use: "branch", |
There was a problem hiding this comment.
Sorry. Actually, this should be a part of av stack branch.
Konboi
changed the title
av branch <new branch> <base branch> commandav stack branch <new branch> <base branch>
|
Fixed |
address #244