[MER-2188] Use gh auth token if it's available #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator. |
twavv
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Looks good. I think @ErichKramer looked into this at some point and identified some reason it might not actually work, so we should get his input on this.
| @@ -149,6 +152,22 @@ func checkCliVersion() { | |||
| var once sync.Once | |||
| var lazyGithubClient *gh.Client | |||
|
|
|||
| func discoverGitHubAPIToken() string { | |||
There was a problem hiding this comment.
Probably just makes sense to call this as part of getClient and return the "github token must be set" error from getClient.
ErichKramer
approved these changes
Aug 22, 2023
draftcode
force-pushed
the
use_gh_token
branch
from
382d0de
to
a5b142f
Compare
draftcode
force-pushed
the
use_gh_token
branch
from
a5b142f
to
712ee3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.