feat: Allow specifying Aviator API URL from configuration #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draftcode
approved these changes
Jul 26, 2023
Current Aviator status
This PR was merged using Aviator. |
ErichKramer
approved these changes
Jul 26, 2023
| src := oauth2.StaticTokenSource( | ||
| &oauth2.Token{AccessToken: config.Av.Aviator.APIToken}, | ||
| ) | ||
| httpClient := oauth2.NewClient(context.Background(), src) | ||
| apiURL := os.Getenv("AV_GRAPHQL_URL") | ||
| if apiURL == "" { | ||
| apiURL = "https://api.aviator.co/graphql" | ||
| baseURL, err := url.Parse(config.Av.Aviator.APIHost) |
There was a problem hiding this comment.
should config take priority or should env var take priority?
Config taking prio makes sense to me.
There was a problem hiding this comment.
I think environment variables should usually take priority since it's easier to override them in more local contexts. My order is always:
- Defaults
- Config files
- Environment variables
- Flags
jainankit
approved these changes
Jul 26, 2023
aviator-app
bot
deleted the
travis/mer-2632-benchling-add-aviator-host-to-av-cli-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request from a customer to support on-prem installations.
Ideally this would be configurable per-repo as it's possible that a user might have some repositories that use the ~~cloud~~ version of Aviator and some that use on-prem, but that's not very likely at this point and I didn't want to add that complexity to this pull request.