Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MER-2419] feat: av pr queue support #188

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

ErichKramer
Copy link
Contributor

No description provided.

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 11, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.

cmd/av/pr_queue.go Outdated Show resolved Hide resolved
cmd/av/pr_queue.go Outdated Show resolved Hide resolved
cmd/av/pr_queue.go Outdated Show resolved Hide resolved
@ErichKramer ErichKramer force-pushed the erich/mer-2419-av-pr-mergequeue branch 2 times, most recently from bd4923f to 584f1ca Compare July 11, 2023 23:42
@ErichKramer ErichKramer requested a review from twavv July 11, 2023 23:43
cmd/av/pr_queue.go Outdated Show resolved Hide resolved
cmd/av/pr_queue.go Outdated Show resolved Hide resolved
cmd/av/pr_queue.go Outdated Show resolved Hide resolved
cmd/av/pr_queue.go Outdated Show resolved Hide resolved
@ErichKramer ErichKramer force-pushed the erich/mer-2419-av-pr-mergequeue branch 3 times, most recently from 2aa9d9c to 048e04a Compare July 12, 2023 20:18
@ErichKramer ErichKramer force-pushed the erich/mer-2419-av-pr-mergequeue branch from 048e04a to e1d6cb1 Compare July 13, 2023 19:50
@ErichKramer ErichKramer requested a review from twavv July 14, 2023 17:02
Short: "queue a pull request for the current branch",
SilenceUsage: true,
Args: cobra.NoArgs,
// error or reterr from emperror.dev/errors here?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't reeeeally matter that much. The main benefit is that if you run with av --debug it will print out stack traces, but the traces would be so shallow at this point that it doesn't matter super hard.

"prNumber": graphql.Int(prNumber),
}

// I have a feeling this would be better written inside of av/internals
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment~ we can move things to internal at some point if we want to.

@aviator-app aviator-app bot merged commit b3ef73d into master Jul 14, 2023
@aviator-app aviator-app bot deleted the erich/mer-2419-av-pr-mergequeue branch July 14, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants