-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MER-2418] Make it easy to detect a PR markdown #165
Conversation
Current Aviator status
This PR was merged using Aviator. |
d5c6c61
to
24d9b56
Compare
I'm fine with excluding the Vim plugin part. I can keep it local. But the PR temp file change is anyway harmless. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. We should also document this - suggest that folks can use the vim plugin or build their own for their IDE (i future we can do a VS code plugin for this).
I wonder if it's possible to include these as extra files installed by (e.g.,) the brew cask. |
It's probably a bit difficult. But since Vim has relatively established plugin install system now, I think it's easy to distribute this as a Vim plugin (by moving these files to another repo). |
This is a nice to have and a harmless change. The temp file created for the pull-request title and body now has an extension '.av.md'. This is anyway recognized as a markdown file for most of the editors, but this extra 'av' extension allows us to have a special file type that supports '%%' as a comment. As an example, added a Vim plugin that recognize this file type and treats '%%' as a comment.
This is a nice to have and a harmless change. The temp file created for
the pull-request title and body now has an extension '.av.md'. This is
anyway recognized as a markdown file for most of the editors, but this
extra 'av' extension allows us to have a special file type that supports
'%%' as a comment.
As an example, added a Vim plugin that recognize this file type and
treats '%%' as a comment.