Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [MER-2339] add av auth status #145

Merged
merged 6 commits into from
Jun 2, 2023
Merged

feat: [MER-2339] add av auth status #145

merged 6 commits into from
Jun 2, 2023

Conversation

doratzeng
Copy link
Contributor

No description provided.

@aviator-app
Copy link
Contributor

aviator-app bot commented Jun 1, 2023 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.

draftcode
draftcode reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@draftcode draftcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you install pre-commit and try formatting files?

twavv
twavv reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@twavv twavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of comments. It's nothing major, just focusing being consistent with other things in the CLI and making sure we have a level of polish for this kind of thing since it's directly end-user facing.

cmd/av/auth_status.go Show resolved Hide resolved
cmd/av/auth_status.go Outdated Show resolved Hide resolved
cmd/av/auth_status.go Outdated Show resolved Hide resolved
cmd/av/auth_status.go Outdated Show resolved Hide resolved
cmd/av/auth_status.go Outdated Show resolved Hide resolved
internal/gql/client.go Outdated Show resolved Hide resolved
internal/gql/client.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
cmd/av/auth_status.go Outdated Show resolved Hide resolved
draftcode
draftcode reviewed Jun 1, 2023
View reviewed changes
internal/avgql/client.go Outdated Show resolved Hide resolved
twavv
twavv approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@twavv twavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

internal/avgql/client.go Outdated Show resolved Hide resolved
@aviator-app aviator-app bot merged commit 5e61a09 into master Jun 2, 2023
@aviator-app aviator-app bot deleted the dt-auth-status branch June 2, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twavv twavv twavv approved these changes

@draftcode draftcode draftcode approved these changes

Assignees
No one assigned
Labels
mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doratzeng @draftcode @twavv