feat: Save PR message if creation fails #113
Conversation
Current Aviator status
This PR was merged using Aviator. |
internal/actions/pr.go
Outdated
| // We need to open an editor to ask the user. Try to populate with | ||
| // reasonable defaults here. | ||
| // If a saved pull request description exists, use that. | ||
| saveFile := filepath.Join(os.TempDir(), fmt.Sprintf("av-pr-%s.md", sanitize.FileName(opts.BranchName))) |
There was a problem hiding this comment.
Can we use avDir
Line 351 in 7d8e52e
There was a problem hiding this comment.
I think tempdir makes sense here. It's decently ephemeral data and it's also possible that if they fail to create a PR using av they'll just create it on GH and we'll never clean up that old data. It's not liable to be more than a few kb for most people but still I think tempfs makes sense here.
There was a problem hiding this comment.
Ephemeral here means it won't survive after reboot. When a machine has a network issue and has to reboot, after reboot the message is lost.
There was a problem hiding this comment.
Yeah, I think that's a fine trade off to make here. Most people don't reboot very often and it's likely (at least I imagine) that if you fail to open a PR you'll deal with it before the next time you'd reboot your machine.
aviator-app
bot
deleted the
travis/mer-2207-save-pr-message-if-pr-creation-fails
branch
Saves the pull request description (entered via editor) to a temporary file if creating the pull request fails. It will re-use the title/description if the user tries to re-create the PR (also just logs the file path to the console in case they want that).
The most common cause of this error (in my experience) is expired auth tokens and/or the base branch of a stack having been deleted on GitHub. (we should provide a better experience for the latter but that's outside the scope of this PR)