fix: Set the parent when creating a PR #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator. |
draftcode
force-pushed
the
set_parent_on_pr_create
branch
from
72f89a7
to
558127b
Compare
jainankit
reviewed
May 8, 2023
| @@ -176,6 +176,7 @@ func CreatePullRequest( | |||
| Name: defaultBranch, | |||
| Trunk: true, | |||
| } | |||
| branchMeta.Parent = parentState | |||
There was a problem hiding this comment.
do you know why the parentState would be empty here to begin with? Just want to make sure we understand when does this particularly happen.
There was a problem hiding this comment.
The parent state is empty when the branch is not created with av, like git checkout -b topic.
There was a problem hiding this comment.
Can this also happen when an associated branch was deleted after merging a parent PR? I think that's what happened in my case.
jainankit
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.