Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix for https://github.com/aviatesk/JET.jl/issues/277 #278

Merged
merged 25 commits into from
Dec 4, 2021
Merged

WIP: fix for https://github.com/aviatesk/JET.jl/issues/277 #278

merged 25 commits into from
Dec 4, 2021

Conversation

goerch
Copy link
Contributor

@goerch goerch commented Dec 3, 2021

Unfortunately some eval tests are broken. I currently have no idea how to fix those...

It seems we have to adapt select_statements to JuliaInterpreter's frame then?

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 3 Dec 2021 - 16:55
  • Baseline: 3 Dec 2021 - 17:13
  • Package commits:
  • Target: 98ed0d
  • Baseline: 7f9498
  • Julia commits:
  • Target: ed9ad6
  • Baseline: ed9ad6
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["cached easy"] 0.85 (5%) ✅ 1.00 (1%)
["easy"] 1.10 (5%) ❌ 1.00 (1%)
["invalidation"] 1.13 (5%) ❌ 1.00 (1%)
["package loading"] 0.88 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 6208 s 1 s 446 s 5468 s 0 s
 #2 2095 MHz 5956 s 1 s 437 s 5743 s 0 s
 
 Memory: 6.788982391357422 GB (3377.98828125 MB free)
 Uptime: 1219.99 sec
 Load Avg: 1.06 1.04 0.84
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 11465 s 1 s 752 s 10609 s 0 s
 #2 2095 MHz 11578 s 1 s 755 s 10507 s 0 s
 
 Memory: 6.788982391357422 GB (3172.6015625 MB free)
 Uptime: 2292.67 sec
 Load Avg: 1.06 1.07 1.02
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 3 Dec 2021 - 16:55
  • Package commit: 98ed0d
  • Julia commit: ed9ad6
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 698.497 ms (5%) 728 bytes (1%) 19
["cached easy"] 4.213 ms (5%) 728 bytes (1%) 19
["easy"] 501.019 ms (5%) 728 bytes (1%) 19
["end to end"] 10.608 s (5%) 146.09 KiB (1%) 239
["first time"] 4.087 s (5%) 920 bytes (1%) 20
["invalidation"] 4.231 s (5%) 752 bytes (1%) 19
["package loading"] 242.115 ms (5%) 648 bytes (1%) 19
["self analysis"] 18.368 s (5%) 960 bytes (1%) 19
["top-level first time"] 6.925 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.537 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 6208 s 1 s 446 s 5468 s 0 s
 #2 2095 MHz 5956 s 1 s 437 s 5743 s 0 s
 
 Memory: 6.788982391357422 GB (3377.98828125 MB free)
 Uptime: 1219.99 sec
 Load Avg: 1.06 1.04 0.84
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 3 Dec 2021 - 17:13
  • Package commit: 7f9498
  • Julia commit: ed9ad6
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 680.282 ms (5%) 728 bytes (1%) 19
["cached easy"] 4.984 ms (5%) 728 bytes (1%) 19
["easy"] 456.031 ms (5%) 728 bytes (1%) 19
["end to end"] 10.948 s (5%) 146.40 KiB (1%) 251
["first time"] 4.062 s (5%) 920 bytes (1%) 20
["invalidation"] 3.750 s (5%) 752 bytes (1%) 19
["package loading"] 274.967 ms (5%) 648 bytes (1%) 19
["self analysis"] 18.742 s (5%) 960 bytes (1%) 19
["top-level first time"] 6.976 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.532 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 11465 s 1 s 752 s 10609 s 0 s
 #2 2095 MHz 11578 s 1 s 755 s 10507 s 0 s
 
 Memory: 6.788982391357422 GB (3172.6015625 MB free)
 Uptime: 2292.67 sec
 Load Avg: 1.06 1.07 1.02
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 2
On-line CPU(s) list: 0,1
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
NUMA node(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Stepping: 4
CPU MHz: 2095.076
BogoMIPS: 4190.15
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB
L1i cache: 64 KiB
L2 cache: 2 MiB
L3 cache: 35.8 MiB
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Full generic retpoline, STIBP disabled, RSB filling
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear

Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x04, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft
JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 3 Dec 2021 - 17:52
  • Baseline: 3 Dec 2021 - 18:10
  • Package commits:
  • Target: 200e0f
  • Baseline: 7f9498
  • Julia commits:
  • Target: ed9ad6
  • Baseline: ed9ad6
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["invalidation"] 1.05 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 6485 s 2 s 416 s 5102 s 0 s
 #2 2593 MHz 5506 s 1 s 390 s 6155 s 0 s
 
 Memory: 6.788982391357422 GB (3495.38671875 MB free)
 Uptime: 1210.45 sec
 Load Avg: 1.01 1.07 0.86
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 12070 s 2 s 717 s 9998 s 0 s
 #2 2593 MHz 10831 s 1 s 684 s 11316 s 0 s
 
 Memory: 6.788982391357422 GB (3188.671875 MB free)
 Uptime: 2290.38 sec
 Load Avg: 1.04 1.04 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 3 Dec 2021 - 17:52
  • Package commit: 200e0f
  • Julia commit: ed9ad6
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 718.553 ms (5%) 728 bytes (1%) 19
["cached easy"] 5.146 ms (5%) 728 bytes (1%) 19
["easy"] 450.814 ms (5%) 728 bytes (1%) 19
["end to end"] 10.962 s (5%) 146.95 KiB (1%) 274
["first time"] 3.988 s (5%) 920 bytes (1%) 20
["invalidation"] 3.801 s (5%) 752 bytes (1%) 19
["package loading"] 246.800 ms (5%) 648 bytes (1%) 19
["self analysis"] 18.104 s (5%) 960 bytes (1%) 19
["top-level first time"] 6.846 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.520 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 6485 s 2 s 416 s 5102 s 0 s
 #2 2593 MHz 5506 s 1 s 390 s 6155 s 0 s
 
 Memory: 6.788982391357422 GB (3495.38671875 MB free)
 Uptime: 1210.45 sec
 Load Avg: 1.01 1.07 0.86
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 3 Dec 2021 - 18:10
  • Package commit: 7f9498
  • Julia commit: ed9ad6
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 721.474 ms (5%) 728 bytes (1%) 19
["cached easy"] 5.137 ms (5%) 728 bytes (1%) 19
["easy"] 440.155 ms (5%) 728 bytes (1%) 19
["end to end"] 11.405 s (5%) 146.91 KiB (1%) 273
["first time"] 3.986 s (5%) 920 bytes (1%) 20
["invalidation"] 3.612 s (5%) 752 bytes (1%) 19
["package loading"] 246.150 ms (5%) 648 bytes (1%) 19
["self analysis"] 18.510 s (5%) 960 bytes (1%) 19
["top-level first time"] 6.941 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.530 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 12070 s 2 s 717 s 9998 s 0 s
 #2 2593 MHz 10831 s 1 s 684 s 11316 s 0 s
 
 Memory: 6.788982391357422 GB (3188.671875 MB free)
 Uptime: 2290.38 sec
 Load Avg: 1.04 1.04 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 2
On-line CPU(s) list: 0,1
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
NUMA node(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Stepping: 7
CPU MHz: 2593.908
BogoMIPS: 5187.81
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB
L1i cache: 64 KiB
L2 cache: 2 MiB
L3 cache: 35.8 MiB
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Full generic retpoline, STIBP disabled, RSB filling
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear

Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft
JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 3 Dec 2021 - 17:52
  • Baseline: 3 Dec 2021 - 18:10
  • Package commits:
  • Target: 200e0f
  • Baseline: 7f9498
  • Julia commits:
  • Target: ed9ad6
  • Baseline: ed9ad6
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["invalidation"] 1.05 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 6485 s 2 s 416 s 5102 s 0 s
 #2 2593 MHz 5506 s 1 s 390 s 6155 s 0 s
 
 Memory: 6.788982391357422 GB (3495.38671875 MB free)
 Uptime: 1210.45 sec
 Load Avg: 1.01 1.07 0.86
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 12070 s 2 s 717 s 9998 s 0 s
 #2 2593 MHz 10831 s 1 s 684 s 11316 s 0 s
 
 Memory: 6.788982391357422 GB (3188.671875 MB free)
 Uptime: 2290.38 sec
 Load Avg: 1.04 1.04 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 3 Dec 2021 - 17:52
  • Package commit: 200e0f
  • Julia commit: ed9ad6
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 718.553 ms (5%) 728 bytes (1%) 19
["cached easy"] 5.146 ms (5%) 728 bytes (1%) 19
["easy"] 450.814 ms (5%) 728 bytes (1%) 19
["end to end"] 10.962 s (5%) 146.95 KiB (1%) 274
["first time"] 3.988 s (5%) 920 bytes (1%) 20
["invalidation"] 3.801 s (5%) 752 bytes (1%) 19
["package loading"] 246.800 ms (5%) 648 bytes (1%) 19
["self analysis"] 18.104 s (5%) 960 bytes (1%) 19
["top-level first time"] 6.846 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.520 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 6485 s 2 s 416 s 5102 s 0 s
 #2 2593 MHz 5506 s 1 s 390 s 6155 s 0 s
 
 Memory: 6.788982391357422 GB (3495.38671875 MB free)
 Uptime: 1210.45 sec
 Load Avg: 1.01 1.07 0.86
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 3 Dec 2021 - 18:10
  • Package commit: 7f9498
  • Julia commit: ed9ad6
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 721.474 ms (5%) 728 bytes (1%) 19
["cached easy"] 5.137 ms (5%) 728 bytes (1%) 19
["easy"] 440.155 ms (5%) 728 bytes (1%) 19
["end to end"] 11.405 s (5%) 146.91 KiB (1%) 273
["first time"] 3.986 s (5%) 920 bytes (1%) 20
["invalidation"] 3.612 s (5%) 752 bytes (1%) 19
["package loading"] 246.150 ms (5%) 648 bytes (1%) 19
["self analysis"] 18.510 s (5%) 960 bytes (1%) 19
["top-level first time"] 6.941 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.530 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1094
Commit ed9ad60f0c (2021-12-02 19:28 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 12070 s 2 s 717 s 9998 s 0 s
 #2 2593 MHz 10831 s 1 s 684 s 11316 s 0 s
 
 Memory: 6.788982391357422 GB (3188.671875 MB free)
 Uptime: 2290.38 sec
 Load Avg: 1.04 1.04 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 2
On-line CPU(s) list: 0,1
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
NUMA node(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Stepping: 7
CPU MHz: 2593.908
BogoMIPS: 5187.81
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB
L1i cache: 64 KiB
L2 cache: 2 MiB
L3 cache: 35.8 MiB
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Full generic retpoline, STIBP disabled, RSB filling
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear

Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft
JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 4 Dec 2021 - 06:05
  • Baseline: 4 Dec 2021 - 06:23
  • Package commits:
  • Target: b76489
  • Baseline: 7f9498
  • Julia commits:
  • Target: ca3fbf
  • Baseline: ca3fbf
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["cached easy"] 0.90 (5%) ✅ 1.00 (1%)
["end to end"] 1.00 (5%) 0.98 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 6068 s 1 s 437 s 9682 s 0 s
 #2 2294 MHz 6155 s 1 s 406 s 9658 s 0 s
 
 Memory: 6.788982391357422 GB (3238.2578125 MB free)
 Uptime: 1628.42 sec
 Load Avg: 1.09 1.05 0.84
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Baseline

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 11387 s 1 s 721 s 14915 s 0 s
 #2 2294 MHz 11829 s 1 s 691 s 14540 s 0 s
 
 Memory: 6.788982391357422 GB (3198.82421875 MB free)
 Uptime: 2714.05 sec
 Load Avg: 1.06 1.05 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 4 Dec 2021 - 6:5
  • Package commit: b76489
  • Julia commit: ca3fbf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 860.150 ms (5%) 728 bytes (1%) 19
["cached easy"] 4.626 ms (5%) 728 bytes (1%) 19
["easy"] 525.734 ms (5%) 728 bytes (1%) 19
["end to end"] 12.375 s (5%) 9.80 KiB (1%) 225
["first time"] 4.844 s (5%) 920 bytes (1%) 20
["invalidation"] 4.461 s (5%) 752 bytes (1%) 19
["package loading"] 253.514 ms (5%) 648 bytes (1%) 19
["self analysis"] 21.949 s (5%) 960 bytes (1%) 19
["top-level first time"] 8.371 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.947 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 6068 s 1 s 437 s 9682 s 0 s
 #2 2294 MHz 6155 s 1 s 406 s 9658 s 0 s
 
 Memory: 6.788982391357422 GB (3238.2578125 MB free)
 Uptime: 1628.42 sec
 Load Avg: 1.09 1.05 0.84
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 4 Dec 2021 - 6:23
  • Package commit: 7f9498
  • Julia commit: ca3fbf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 877.659 ms (5%) 728 bytes (1%) 19
["cached easy"] 5.112 ms (5%) 728 bytes (1%) 19
["easy"] 528.623 ms (5%) 728 bytes (1%) 19
["end to end"] 12.424 s (5%) 10.02 KiB (1%) 245
["first time"] 4.793 s (5%) 920 bytes (1%) 20
["invalidation"] 4.429 s (5%) 752 bytes (1%) 19
["package loading"] 254.081 ms (5%) 648 bytes (1%) 19
["self analysis"] 22.133 s (5%) 960 bytes (1%) 19
["top-level first time"] 8.390 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.945 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 11387 s 1 s 721 s 14915 s 0 s
 #2 2294 MHz 11829 s 1 s 691 s 14540 s 0 s
 
 Memory: 6.788982391357422 GB (3198.82421875 MB free)
 Uptime: 2714.05 sec
 Load Avg: 1.06 1.05 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 2
On-line CPU(s) list: 0,1
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
NUMA node(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 79
Model name: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Stepping: 1
CPU MHz: 2294.687
BogoMIPS: 4589.37
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB
L1i cache: 64 KiB
L2 cache: 512 KiB
L3 cache: 50 MiB
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Full generic retpoline, STIBP disabled, RSB filling
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear

Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor :Intel
Architecture :Broadwell
Model Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 51200) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft
JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 4 Dec 2021 - 06:05
  • Baseline: 4 Dec 2021 - 06:23
  • Package commits:
  • Target: b76489
  • Baseline: 7f9498
  • Julia commits:
  • Target: ca3fbf
  • Baseline: ca3fbf
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["cached easy"] 0.90 (5%) ✅ 1.00 (1%)
["end to end"] 1.00 (5%) 0.98 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 6068 s 1 s 437 s 9682 s 0 s
 #2 2294 MHz 6155 s 1 s 406 s 9658 s 0 s
 
 Memory: 6.788982391357422 GB (3238.2578125 MB free)
 Uptime: 1628.42 sec
 Load Avg: 1.09 1.05 0.84
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Baseline

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 11387 s 1 s 721 s 14915 s 0 s
 #2 2294 MHz 11829 s 1 s 691 s 14540 s 0 s
 
 Memory: 6.788982391357422 GB (3198.82421875 MB free)
 Uptime: 2714.05 sec
 Load Avg: 1.06 1.05 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 4 Dec 2021 - 6:5
  • Package commit: b76489
  • Julia commit: ca3fbf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 860.150 ms (5%) 728 bytes (1%) 19
["cached easy"] 4.626 ms (5%) 728 bytes (1%) 19
["easy"] 525.734 ms (5%) 728 bytes (1%) 19
["end to end"] 12.375 s (5%) 9.80 KiB (1%) 225
["first time"] 4.844 s (5%) 920 bytes (1%) 20
["invalidation"] 4.461 s (5%) 752 bytes (1%) 19
["package loading"] 253.514 ms (5%) 648 bytes (1%) 19
["self analysis"] 21.949 s (5%) 960 bytes (1%) 19
["top-level first time"] 8.371 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.947 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 6068 s 1 s 437 s 9682 s 0 s
 #2 2294 MHz 6155 s 1 s 406 s 9658 s 0 s
 
 Memory: 6.788982391357422 GB (3238.2578125 MB free)
 Uptime: 1628.42 sec
 Load Avg: 1.09 1.05 0.84
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 4 Dec 2021 - 6:23
  • Package commit: 7f9498
  • Julia commit: ca3fbf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 877.659 ms (5%) 728 bytes (1%) 19
["cached easy"] 5.112 ms (5%) 728 bytes (1%) 19
["easy"] 528.623 ms (5%) 728 bytes (1%) 19
["end to end"] 12.424 s (5%) 10.02 KiB (1%) 245
["first time"] 4.793 s (5%) 920 bytes (1%) 20
["invalidation"] 4.429 s (5%) 752 bytes (1%) 19
["package loading"] 254.081 ms (5%) 648 bytes (1%) 19
["self analysis"] 22.133 s (5%) 960 bytes (1%) 19
["top-level first time"] 8.390 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.945 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 11387 s 1 s 721 s 14915 s 0 s
 #2 2294 MHz 11829 s 1 s 691 s 14540 s 0 s
 
 Memory: 6.788982391357422 GB (3198.82421875 MB free)
 Uptime: 2714.05 sec
 Load Avg: 1.06 1.05 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 2
On-line CPU(s) list: 0,1
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
NUMA node(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 79
Model name: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Stepping: 1
CPU MHz: 2294.687
BogoMIPS: 4589.37
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB
L1i cache: 64 KiB
L2 cache: 512 KiB
L3 cache: 50 MiB
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Full generic retpoline, STIBP disabled, RSB filling
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear

Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor :Intel
Architecture :Broadwell
Model Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 51200) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft
JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 4 Dec 2021 - 07:14
  • Baseline: 4 Dec 2021 - 07:32
  • Package commits:
  • Target: f5adc5
  • Baseline: f593fd
  • Julia commits:
  • Target: ca3fbf
  • Baseline: ca3fbf
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["end to end"] 1.00 (5%) 0.98 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
 speed user nice sys idle irq
 #1 2397 MHz 6147 s 2 s 423 s 7098 s 0 s
 #2 2397 MHz 6165 s 1 s 398 s 7117 s 0 s
 
 Memory: 6.788982391357422 GB (3246.546875 MB free)
 Uptime: 1374.94 sec
 Load Avg: 1.06 1.03 0.84
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Baseline

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
 speed user nice sys idle irq
 #1 2397 MHz 11848 s 2 s 706 s 11897 s 0 s
 #2 2397 MHz 11399 s 1 s 676 s 12386 s 0 s
 
 Memory: 6.788982391357422 GB (3217.734375 MB free)
 Uptime: 2454.69 sec
 Load Avg: 1.0 1.04 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 4 Dec 2021 - 7:14
  • Package commit: f5adc5
  • Julia commit: ca3fbf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 841.860 ms (5%) 728 bytes (1%) 19
["cached easy"] 4.733 ms (5%) 728 bytes (1%) 19
["easy"] 523.328 ms (5%) 728 bytes (1%) 19
["end to end"] 12.377 s (5%) 10.05 KiB (1%) 236
["first time"] 4.795 s (5%) 920 bytes (1%) 20
["invalidation"] 4.403 s (5%) 752 bytes (1%) 19
["package loading"] 252.526 ms (5%) 648 bytes (1%) 19
["self analysis"] 26.013 s (5%) 960 bytes (1%) 19
["top-level first time"] 8.253 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.922 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
 speed user nice sys idle irq
 #1 2397 MHz 6147 s 2 s 423 s 7098 s 0 s
 #2 2397 MHz 6165 s 1 s 398 s 7117 s 0 s
 
 Memory: 6.788982391357422 GB (3246.546875 MB free)
 Uptime: 1374.94 sec
 Load Avg: 1.06 1.03 0.84
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 4 Dec 2021 - 7:32
  • Package commit: f593fd
  • Julia commit: ca3fbf
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 841.117 ms (5%) 728 bytes (1%) 19
["cached easy"] 4.642 ms (5%) 728 bytes (1%) 19
["easy"] 506.215 ms (5%) 728 bytes (1%) 19
["end to end"] 12.331 s (5%) 10.28 KiB (1%) 246
["first time"] 4.714 s (5%) 920 bytes (1%) 20
["invalidation"] 4.394 s (5%) 752 bytes (1%) 19
["package loading"] 253.039 ms (5%) 648 bytes (1%) 19
["self analysis"] 25.302 s (5%) 960 bytes (1%) 19
["top-level first time"] 8.229 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.991 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.1097
Commit ca3fbf15b7 (2021-12-03 20:30 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.11.0-1021-azure #22~20.04.1-Ubuntu SMP Fri Oct 29 01:11:25 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
 speed user nice sys idle irq
 #1 2397 MHz 11848 s 2 s 706 s 11897 s 0 s
 #2 2397 MHz 11399 s 1 s 676 s 12386 s 0 s
 
 Memory: 6.788982391357422 GB (3217.734375 MB free)
 Uptime: 2454.69 sec
 Load Avg: 1.0 1.04 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 2
On-line CPU(s) list: 0,1
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
NUMA node(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 63
Model name: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Stepping: 2
CPU MHz: 2397.217
BogoMIPS: 4794.43
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB
L1i cache: 64 KiB
L2 cache: 512 KiB
L3 cache: 30 MiB
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Full generic retpoline, STIBP disabled, RSB filling
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear

Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Vendor :Intel
Architecture :Haswell
Model Family: 0x06, Model: 0x3f, Stepping: 0x02, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 30720) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

Using an internal implementation detaill of `JuliaInterpreter` to *not* optimize `FrameCode`
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #278 (94dbe59) into master (7f9498b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   89.07%   89.09%   +0.01%     
==========================================
  Files          10       10              
  Lines        2225     2228       +3     
==========================================
+ Hits         1982     1985       +3     
  Misses        243      243              
Impacted Files Coverage Δ
src/toplevel/virtualprocess.jl 97.37% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9498b...94dbe59. Read the comment docs.

@goerch goerch changed the title WIP: fix for https://github.com/aviatesk/JET.jl/issues/277 and https://github.com/aviatesk/JET.jl/issues/224 WIP: fix for https://github.com/aviatesk/JET.jl/issues/277 Dec 3, 2021
Copy link
Owner

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Are you willing to add a testcase for this?
In a case of when JuliaInterpreter.optimize! is necessary for successful interpretation,
then as an alternative, we may even change JuliaInterpreter.optimize! so that it takes a callback that is invoked upon source modification.
This is just a suggestion, if you feel it would be complicated, we can just go ahead and merge this.

@goerch Also, here're tips for you when working on git projects and GitHub :)

  • in order to keep commit history clean, it's generally better to keep the default branch of your fork up-to-dated with that of the original repository (i.e. git pull origin (master|main) occasionally), and cut a separate branch when working on something and create a PR from there
  • in commit messages, it would give us extra fancy features if you use issue numbers (e.g. #277) rather than entire URL (e.g. https://github.com/aviatesk/JET.jl/issues/277), like GitHub automatically closes the referenced issue upon merging this PR

src/toplevel/virtualprocess.jl Outdated Show resolved Hide resolved
@goerch
Copy link
Contributor Author

goerch commented Dec 4, 2021

Good catch! Are you willing to add a testcase for this?

Yes.

In a case of when JuliaInterpreter.optimize! is necessary for successful interpretation,
then as an alternative, we may even change JuliaInterpreter.optimize! so that it takes a callback that is invoked upon source modification.

This version of JET currently produces

═════ 1 toplevel error found ═════
┌ @ C:\Users\Win10\.julia\packages\ScanByte\BvBXC\src\codegen.jl:20 
│ invalid lookup expr Core.svec()
│ Stacktrace:
│   [1] error(::String, ::Expr)
│     @ Base .\error.jl:42
│   [2] lookup_expr(frame::JuliaInterpreter.Frame, e::Expr)
│     @ JuliaInterpreter C:\Users\Win10\.julia\packages\JuliaInterpreter\4B89D\src\interpret.jl:25
│   [3] collect_args(frame::JuliaInterpreter.Frame, call_expr::Expr; isfc::Bool)
│     @ JuliaInterpreter C:\Users\Win10\.julia\packages\JuliaInterpreter\4B89D\src\interpret.jl:60
│   [4] evaluate_foreigncall(frame::JuliaInterpreter.Frame, call_expr::Expr)
│     @ JuliaInterpreter C:\Users\Win10\.julia\packages\JuliaInterpreter\4B89D\src\interpret.jl:151
│   [5] eval_rhs(recurse::Any, frame::JuliaInterpreter.Frame, node::Expr)
│     @ JuliaInterpreter C:\Users\Win10\.julia\packages\JuliaInterpreter\4B89D\src\interpret.jl:402
│   [6] step_expr!(recurse::Any, frame::JuliaInterpreter.Frame, node::Any, istoplevel::Bool)
│     @ JuliaInterpreter C:\Users\Win10\.julia\packages\JuliaInterpreter\4B89D\src\interpret.jl:474
│   [7] step_expr!(interp::JET.ConcreteInterpreter{JET.JETAnalyzer{JET.BasicPass{typeof(JET.basic_function_filter)}}, Expr}, frame::JuliaInterpreter.Frame, node::Any, istoplevel::Bool)
│     @ JET C:\Users\Win10\Documents\GitHub\JET.jl\src\toplevel\virtualprocess.jl:974
│   [8] step_expr!(recurse::Any, frame::JuliaInterpreter.Frame, istoplevel::Bool)
│     @ JuliaInterpreter C:\Users\Win10\.julia\packages\JuliaInterpreter\4B89D\src\interpret.jl:611
│   [9] selective_eval!(recurse::Any, frame::JuliaInterpreter.Frame, isrequired::Vector{Bool}, istoplevel::Bool)
│     @ LoweredCodeUtils C:\Users\Win10\.julia\packages\LoweredCodeUtils\jZY56\src\codeedges.jl:850
│  [10] selective_eval_fromstart!
│     @ C:\Users\Win10\.julia\packages\LoweredCodeUtils\jZY56\src\codeedges.jl:875 [inlined]
│  [11] partially_interpret!(interp::JET.ConcreteInterpreter{JET.JETAnalyzer{JET.BasicPass{typeof(JET.basic_function_filter)}}, Expr}, mod::Module, src::Core.CodeInfo)
│     @ JET C:\Users\Win10\Documents\GitHub\JET.jl\src\toplevel\virtualprocess.jl:807
│  [12] _virtual_process!(toplevelex::Expr, filename::String, analyzer::JET.JETAnalyzer{JET.BasicPass{typeof(JET.basic_function_filter)}}, config::JET.ToplevelConfig{Expr}, context::Module, res::JET.VirtualProcessResult)
│     @ JET C:\Users\Win10\Documents\GitHub\JET.jl\src\toplevel\virtualprocess.jl:630
└───────────────────────────────────────────────────────────────────

for #224, so it seems to me we somehow depend on optimized code? Do you have an idea where I could search for the cause of the above trace? I believe one solution could be to come up with a scheme to reflect the changes of optimization in the concretize vector.

@aviatesk
Copy link
Owner

aviatesk commented Dec 4, 2021

Maybe JuliaDebug/JuliaInterpreter.jl#13 (comment)?
Or we can create Frame with optimization first and then select statements.

@goerch
Copy link
Contributor Author

goerch commented Dec 4, 2021

Or we can create Frame with optimization first and then select statements.

This I tried first :) and it had too much fallout in JET for me to handle (it broke eval tests IIRC).

Maybe JuliaDebug/JuliaInterpreter.jl#13 (comment)?

Absolutely: this is exactly our problem! So given they probably won't fix this for the time being, we would need an interface along the lines of

    selective_eval_fromstart!(interp, mod, src, concretize, optimize, #= istoplevel =# true)

or we switch to optimized JuliaInterpreter frames internally and handle the fallout?

@goerch
Copy link
Contributor Author

goerch commented Dec 4, 2021

I'd like to propose the following:

  • Merging this change as is (it seems to be a bug fix at least)
  • Me learning some git (Thanks for the tips!)
  • Switching internally to optimized frames in another pull request and talking there about the eval problems.

@aviatesk aviatesk merged commit b1c5ede into aviatesk:master Dec 4, 2021
@aviatesk
Copy link
Owner

aviatesk commented Dec 4, 2021

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants