Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go RabbitMQ Client Library into README.md file #3831

Merged
merged 3 commits into from
Oct 17, 2021

Conversation

Thanakorn-ki
Copy link
Contributor

@Thanakorn-ki Thanakorn-ki commented Oct 13, 2021

  • Add the rabbitmq go client

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below before you submit PR:
not every repository (project) will fit into every option, but most projects should

  • I have added my package in alphabetical order.
  • I have an appropriate description with correct grammar.
  • I know that this package was not listed before.
  • I have added pkg.go.dev link to the repo and to my pull request.
  • I have added coverage service link to the repo and to my pull request.
  • I have added goreportcard link to the repo and to my pull request.
  • I have read Contribution guidelines, maintainers note and Quality standard.

Thanks for your PR, you're awesome! 👍

- Add the rabbitmq go client
@avelino
Copy link
Owner

avelino commented Oct 13, 2021

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body links content check:

  • godoc.org or pkg.go.dev: True
  • goreportcard.com: False
  • coverage: True

your project is about to be approved, it's under revision, it may take a few days

@Thanakorn-ki Thanakorn-ki changed the title Update README.md Update RabbitMQ go client into README.md file Oct 13, 2021
@Thanakorn-ki
Copy link
Contributor Author

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body links content check:

  • godoc.org or pkg.go.dev: True
  • goreportcard.com: False
  • coverage: True

your project is about to be approved, it's under revision, it may take a few days

Already updated, Please review again. 😄

Copy link
Collaborator

@phanirithvij phanirithvij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The description should be the repository's description.
  • Name is amqp
  • Not in alphabetical order

Please fix these three then it will be added.

@Thanakorn-ki Thanakorn-ki changed the title Update RabbitMQ go client into README.md file Update Go RabbitMQ Client Library into README.md file Oct 14, 2021
@Thanakorn-ki
Copy link
Contributor Author

  • The description should be the repository's description.
  • Name is amqp
  • Not in alphabetical order

Please fix these three then it will be added.

Fixed.

@phanirithvij phanirithvij self-requested a review October 15, 2021 04:07
Copy link
Collaborator

@phanirithvij phanirithvij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thanakorn-ki I've looked at the repo issues to figure out why there was no activity in the past year, this discussion streadway/amqp#497 mentions the newly updated location for the repo maintained by the rabbitmq team, over at https://github.com/rabbitmq/amqp091-go.

I suggest you change it to this as it is currently active and maintained.
I've only investigated and found out just now.

Please make this change and I will approve for merge.

@Thanakorn-ki
Copy link
Contributor Author

@Thanakorn-ki I've looked at the repo issues to figure out why there was no activity in the past year, this discussion streadway/amqp#497 mentions the newly updated location for the repo maintained by the rabbitmq team, over at https://github.com/rabbitmq/amqp091-go.

I suggest you change it to this as it is currently active and maintained. I've only investigated and found out just now.

Please make this change and I will approve for merge.

OMG, Thank and then will be updated.

@phanirithvij phanirithvij merged commit 5ce5710 into avelino:master Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants