Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pureconfig Toggle #982

Merged
merged 15 commits into from
Oct 3, 2022
Merged

Pureconfig Toggle #982

merged 15 commits into from
Oct 3, 2022

Conversation

nb-ceffa
Copy link
Contributor

@nb-ceffa nb-ceffa commented Sep 17, 2022 •
edited
Loading

@nb-ceffa nb-ceffa self-assigned this Sep 17, 2022
@jakubjanecek
Copy link
Collaborator

Could you please describe what you are trying to achieve with WithConfig and Toggle? Also the build is failing and it would be nice to add some documentation for this.

@nb-ceffa nb-ceffa changed the title Pureconfig toggle Pureconfig Toggle typeclass Sep 17, 2022
jakubjanecek
jakubjanecek requested changes Sep 18, 2022
View reviewed changes
Copy link
Collaborator

@jakubjanecek jakubjanecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

I do have some requests for improvement. Please, try to have another look at it.

pureconfig/README.md Outdated Show resolved Hide resolved
pureconfig/README.md Outdated Show resolved Hide resolved
pureconfig/src/main/scala/com/avast/sst/pureconfig/WithConfig.scala Outdated Show resolved Hide resolved
pureconfig/src/main/scala/com/avast/sst/pureconfig/WithConfig.scala Show resolved Hide resolved
pureconfig/src/test/scala-2/com/avast/sst/pureconfig/ToggleTest.scala Outdated Show resolved Hide resolved
pureconfig/src/test/scala-3/com/avast/sst/pureconfig/ToggleTest.scala Outdated Show resolved Hide resolved
pureconfig/README.md Outdated Show resolved Hide resolved
@nb-ceffa nb-ceffa requested a review from jakubjanecek October 1, 2022 17:51
jakubjanecek
jakubjanecek approved these changes Oct 2, 2022
View reviewed changes
Copy link
Collaborator

@jakubjanecek jakubjanecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. It's ok now. I just have some suggestions in the documentation.

site/docs/subprojects/pureconfig.md Outdated Show resolved Hide resolved
site/docs/subprojects/pureconfig.md Outdated Show resolved Hide resolved
site/docs/subprojects/pureconfig.md Outdated Show resolved Hide resolved
site/docs/subprojects/pureconfig.md Outdated Show resolved Hide resolved
@jakubjanecek jakubjanecek added the mergify-wait Force Mergify to wait with automatic merging label Oct 2, 2022
@nb-ceffa nb-ceffa removed the request for review from tomasherman October 3, 2022 07:46
@jakubjanecek jakubjanecek enabled auto-merge (squash) October 3, 2022 07:47
@jakubjanecek jakubjanecek merged commit 36f3760 into master Oct 3, 2022
@jakubjanecek jakubjanecek deleted the pureconfig_toggle branch October 3, 2022 07:54
@nb-ceffa nb-ceffa changed the title Pureconfig Toggle typeclass Pureconfig Toggle Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjanecek jakubjanecek jakubjanecek approved these changes

Assignees

@nb-ceffa nb-ceffa

Labels
mergify-wait Force Mergify to wait with automatic merging
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nb-ceffa @jakubjanecek