Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Micrometer module for Prometheus metrics #715

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Implement Micrometer module for Prometheus metrics #715

merged 2 commits into from
Oct 26, 2021

Conversation

havelkahonza
Copy link
Contributor

No description provided.

jakubjanecek
jakubjanecek reviewed Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@jakubjanecek jakubjanecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a small stylistic change.

And just to be sure before I approve, the default configuration values are copied from the underlying library right?

Thanks.

@havelkahonza
Copy link
Contributor Author

I've made a small stylistic change.

And just to be sure before I approve, the default configuration values are copied from the underlying library right?

Thanks.

Right. It is taken straight from the PrometheusConfig interface.

@mergify mergify bot merged commit 2071363 into master Oct 26, 2021
@mergify mergify bot deleted the feat/prometheus branch October 26, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjanecek jakubjanecek jakubjanecek approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havelkahonza @jakubjanecek