Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Setup sbt-version-policy #484

Merged
merged 2 commits into from
Mar 8, 2021
Merged

build: Setup sbt-version-policy #484

merged 2 commits into from
Mar 8, 2021

Conversation

jakubjanecek
Copy link
Collaborator

No description provided.

@jakubjanecek
Copy link
Collaborator Author

I want to integrate this with #199 so I'm merging this. I'll change anything if you have some comments.

@jakubjanecek jakubjanecek merged commit 45230ac into master Mar 8, 2021
@jakubjanecek jakubjanecek deleted the build/tweaks branch March 8, 2021 20:30
@@ -14,4 +14,4 @@ jobs:
with:
extraKey: pr-${GITHUB_HEAD_REF}
- name: Check/Compile/Test
run: sbt check
run: sbt versionPolicyCheck check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make more sense to put versionPolicyCheck into check

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that but this is supposed to be run on PRs only and we also run check during release where you want to run versionCheck. So I did it this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants