Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding configuration options for blocking executor to ExecutorModule #593

Closed
okubis opened this issue Jun 11, 2021 · 0 comments · Fixed by #594
Closed

Consider adding configuration options for blocking executor to ExecutorModule #593

okubis opened this issue Jun 11, 2021 · 0 comments · Fixed by #594
Labels
feature New feature or request

Comments

@okubis
Copy link

okubis commented Jun 11, 2021

It would be useful to have the option to configure coreSize and keepAlive values in ThreadPoolExecutorConfig passed to the blocking executor during its creation via ExecutorModule make methods.
Since by default the coreSize is set to 0 and the keepAlive to 1000 millis, there might be a large number of blocking threads created and closed if a program schedules repeated task to blocking executor with interval higher than the keepAlive.

It would be nice to add these parameters to the existing methods with default values set to the current value either directly or wrapped in the ThreadPoolExecutorConfig.
@okubis okubis added the feature New feature or request label Jun 11, 2021
jakubjanecek added a commit that referenced this issue Jun 12, 2021
@jakubjanecek
fix: Set default value for thread keep-alive to 1 minute
6bfa7ee 
feat: Make blocking thread pool executor configurable

Closes #593
@jakubjanecek jakubjanecek mentioned this issue Jun 12, 2021
Merged
@mergify mergify bot closed this as completed in #594 Jun 23, 2021
mergify bot pushed a commit that referenced this issue Jun 23, 2021
@jakubjanecek
fix: Set default value for thread keep-alive to 1 minute (#594)
35014b5 
feat: Make blocking thread pool executor configurable

Closes #593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Set default value for thread keep-alive to 1 minute avast/scala-server-toolkit
1 participant
@okubis