Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocated length of errorLog should be 1 and not config.attempts if lastErrorOnly is set to true in the config. #22

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

amukherj
Copy link
Contributor

@amukherj amukherj commented Nov 26, 2019

This allows O(1) memory to be used with retries, whenever lastErrorOnly is set.

Addresses #23.

… `lastErrorOnly` is set to true in the config.
@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #22 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #22      +/-   ##
=========================================
+ Coverage   97.14%   97.4%   +0.25%     
=========================================
  Files           2       2              
  Lines          70      77       +7     
=========================================
+ Hits           68      75       +7     
  Misses          2       2
Impacted Files Coverage Δ
retry.go 96.36% <100%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a322e24...2c27f34. Read the comment docs.

@amukherj
Copy link
Contributor Author

@JaSei, could you help validate this PR and the issue (#23)? Thanks.

@JaSei JaSei merged commit 5b72a4d into avast:master Nov 27, 2019
@JaSei
Copy link
Collaborator

JaSei commented Nov 27, 2019

Thanks for you PR

@JaSei
Copy link
Collaborator

JaSei commented Nov 27, 2019

version 2.4.3 was released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants