[36] – Refactor: NextJs AppDir #54
Conversation
| 'id', | ||
| 'portal_link', | ||
| 'signup_form_id', | ||
| 'owner_id', |
There was a problem hiding this comment.
why is owner id part of code..
There was a problem hiding this comment.
bcz getting owner_id from api response, so deleting it before creating a new session.
| 'name', | ||
| 'id', | ||
| 'portal_link', | ||
| 'signup_form_id', |
There was a problem hiding this comment.
i think we can retain this
There was a problem hiding this comment.
provided signup_form is true
There was a problem hiding this comment.
okay, will change it accordingly when needed
| { label: 'Activate Sign-Up', value: data.is_active ? 'Yes' : 'No' }, | ||
| { label: 'Is pop up form allowed', value: data.popup_form ? 'Yes' : 'No' }, | ||
| { | ||
| label: 'Number fields in pop up form', |
There was a problem hiding this comment.
Number of fields in Popup Form
| { | ||
| label: 'Number fields in pop up form', | ||
| value: data.meta_data?.number_of_fields_in_popup_form, | ||
| }, |
There was a problem hiding this comment.
Is Redirection allowed?
| value: data.meta_data?.number_of_fields_in_popup_form, | ||
| }, | ||
| { label: 'Is redirection allowed', value: data.redirection ? 'Yes' : 'No' }, | ||
| { label: 'Is Id generation allowed', value: data.id_generation ? 'Yes' : 'No' }, |
There was a problem hiding this comment.
Is ID Generation allowed?
| }, | ||
| { label: 'Is redirection allowed', value: data.redirection ? 'Yes' : 'No' }, | ||
| { label: 'Is Id generation allowed', value: data.id_generation ? 'Yes' : 'No' }, | ||
| { label: 'Signup form name', value: data.meta_data?.signup_form_name ?? 'N/A' }, |
There was a problem hiding this comment.
note that this is displayed only if signup_form is true etc .. if signup_form is false then no need to show.
infact if session type is "sign-in" or "sign-in with forgot id" .. signup_form should be false and signup_form_name option shoudln't be displayed at all.
keep in mind for later if not this PR. make an issue in github repo
There was a problem hiding this comment.
Created a Issue for this #59,
| }, | ||
| { label: 'Marking Scheme', value: data.meta_data?.marking_scheme }, | ||
| { label: 'Optional Limits', value: data.meta_data?.optional_limits }, | ||
| { label: 'Show Answers', value: data.meta_data?.show_answers ? 'Yes' : 'No' }, |
There was a problem hiding this comment.
why is this not getting deleted in duplicate columns
| type: 'select', | ||
| options: AuthOptions, | ||
| label: 'Auth type', | ||
| placeholder: 'Select a auth type', |
| }, | ||
| activateSignUp: { | ||
| type: 'switch', | ||
| label: 'Activate sign up', |
There was a problem hiding this comment.
Activate Sign Up .. just check caps throughout
| }, | ||
| isPopupForm: { | ||
| type: 'switch', | ||
| label: 'Is pop up form allowed', |
| }, | ||
| noOfFieldsInPopup: { | ||
| type: 'number', | ||
| label: 'No of fields in popup', |
There was a problem hiding this comment.
Number of fields in popup form
|
|
||
| return ( | ||
| <main className="container text-center"> | ||
| <h2>TO BE IMPLEMENTED {(sessionData as Session)?.name}</h2> |
There was a problem hiding this comment.
Thought of creating a seperate page for showing the Session details of perticular session.
| @@ -0,0 +1,76 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
for these ui tsx files.. follow the same naming convention na.. capitalize the file name? Card.tsx, Checkbox.tsx etc..
There was a problem hiding this comment.
The thing is using shadCn UI, it creates the Files automatically using cli, and these files have small cases.
| auth_type: AuthType.ID, | ||
| id_generation: false, | ||
| redirection: false, | ||
| signup_form: true, |
There was a problem hiding this comment.
why are signup_form_name / signup_form_id not here
There was a problem hiding this comment.
check for other cases too
| infinite_session: false, | ||
| date_created: new Date(), | ||
| }, | ||
| purpose: { |
There was a problem hiding this comment.
this will change for liveclass
| session_id: '', | ||
| meta_data: { | ||
| ...formData.meta_data, | ||
| report_link: '', |
There was a problem hiding this comment.
wont be there for non quiz platform.. next pr
Issues Fixed: #56 #57 #45 #15 #18 #19 #20 #25
Tasks: