Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous UI issues #26

Merged
merged 6 commits into from
Oct 15, 2023
Merged

Miscellaneous UI issues #26

merged 6 commits into from
Oct 15, 2023

Conversation

Prakhar-commits
Copy link
Contributor

@Prakhar-commits Prakhar-commits commented Sep 12, 2023 •
edited
Loading

Fixes #22 and #18

Summary

Adds the method for users to navigate through pages and modal when the session-data is sent and user is navigated to the home page

Test Plan

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
    • Safari (use BrowserStack)
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable:
      • update docs/ENV.md
      • update Github Workflow files
      • update DockerFile
      • update the secrets for staging and production
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVGs without text have their aria-label attributes set

suryabulusu
suryabulusu reviewed Oct 13, 2023
View reviewed changes
src/pages/SessionCreator.tsx Outdated
@@ -2,8 +2,10 @@ import Stepper from "@/components/Stepper";
import StudentDetails from "@/components/Steps/StudentDetails";
import { TestDetails } from "@/components/Steps/TestDetails";
import Timeline from "@/components/Steps/Timeline";
// import { SessionData } from "@/types/FormTypes";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved , was experimenting on getting session-data before

suryabulusu
suryabulusu approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@suryabulusu suryabulusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes left.. looks good

@Prakhar-commits Prakhar-commits merged commit 167af0a into main Oct 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryabulusu suryabulusu suryabulusu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Session added box once Submit is clicked
2 participants
@Prakhar-commits @suryabulusu