Don't remove file_location since it is used to render the file's filename

[cjcolvar]

Thanks to John Merritt of University of Louisville for pointing out this issue in avalon slack.

[masaball]

This change looks good. It does make me think though should we consider uncoupling the direct association of section name and file location? It feels a little weird to continue storing a file location when the file has actually been removed.

[cjcolvar]

I think we're still storing a file location when we move the file and the file might then get moved to tape off disk. So I'm thinking retaining it here is somewhat analogous. If a section title is manually entered then we use that for section name but fallback to file location. I'm wondering if we should store original filename in a separate field to get that decoupling that you're suggesting.

[masaball]

That's a good point about the files being moved to tape storage being analogous...

If we were to decouple, I think storing original filename as a separate field would probably be the easiest/most sensible approach.

I am fine with either approach.

[joncameron]

I think it's OK to merge this in without the extra step of decoupling, and I'll create a new issue for adding a new field. Storing the original filename in a separate field sounds like a good change.

Issue: #6109