Move Babel transforms to the main process. #349

jamestalmage · 2015-12-22T09:31:40Z

This moves Babel transforms to the main process, and caches the transpiled results.

It uses caching-transform to provide caching. Expensive requires (like babel) are placed inside the factory function, which caching-transform only calls when it determines it needs to transform a file.

The path to each precompiled test is passed in the options object to fork:

fork('/path/to/file.js', {
  precompiled: {
    '/path/to/file.js': '/path/to/cached/file.js'
  }
});

It uses require-precompiled to install a require hook that pulls the transformed file from the cache.

The caching directory is used by the users package.json, and installing in node_modules/.cache/ava.
If the cache directory cannot be found (i.e. if they have no package.json), or the user provides a --no-cache flag, pre-compilation still happens on the main thread - but results are published to a temp directory.

Speedup is dramatic.
Using the 6.0.0 branch of got:

ava master branch

$ time ava
# npm 2
ava  85.51s user 7.19s system 592% cpu 15.650 total
# npm 3
ava  24.87s user 1.91s system 384% cpu 6.957 total

this branch using --no-cache

$ time ava --no-cache
# npm 2
ava --no-cache  11.19s user 1.05s system 130% cpu 9.379 total
# npm 3
ava --no-cache  7.59s user 0.75s system 134% cpu 6.217 total

This branch with caching enabled

$ time ava
# npm 2
ava  7.86s user 0.81s system 193% cpu 4.484 total
# npm 3
ava  6.64s user 0.72s system 173% cpu 4.237 total

A couple points of interest here:

This drastically reduces the penalty for sticking with npm 2 even on your first run.
You absolutely should upgrade to npm 3 for the best performance.

vadimdemedes · 2015-12-22T16:07:03Z

Rebase went wrong here.

jamestalmage · 2015-12-22T17:06:01Z

Rebase went wrong here.

It wasn't like that last night.

sindresorhus · 2015-12-22T19:36:00Z

package.json

-    "test": "xo && tap --coverage --reporter=spec --timeout=150 test/*.js",
-    "test-win": "tap --reporter=spec --timeout=150 test/*.js",
-    "coverage": "tap --coverage-report=lcov"
+    "pretest": "rm -rf ./node_modules/.cache",


Use https://github.com/sindresorhus/del-cli to make it work on Windwos too.

OK, I tried trash-cli first but it fails if the directory doesn't exist. Was just about to push rimraf, does del-cli accept missing directories?

@jamestalmage Re trash-cli, that's a bug sindresorhus/trash#43, but no point in having the overhead of moving it to the trash, not something you'd ever care about restoring.

jamestalmage · 2015-12-22T19:52:57Z

@sindresorhus I used rimraf over del-cli, because sindresorhus/del-cli#3

jamestalmage · 2015-12-22T20:09:38Z

Hmm, it seems implementing caching fixed my Windows errors. I previously saw some errors that made me suspicious the problem was in temp-write. I'm even more suspicious now.

sindresorhus · 2015-12-22T20:10:30Z

@jamestalmage del-cli now supports Node.js 0.10.

jamestalmage · 2015-12-22T20:11:42Z

OK, cool.
I'm heading out for ~4 hours. I will apply all the suggested changes later tonight.

There are many failing tests, but it basically works.

The latest `nyc` uses `append-transform`, which means multiple require extensions can be installed on top of the one `nyc` installs. Previous versions of nyc only allowed one additional transform before breaking. This allows us to use `require-precompiled` and users can still add `babel/register` (whenever we get those working).

`tap` automatically uploads coverage to coveralls for branches, but not PR's. That required an ugly workaround in .travis.yml to manually upload only for PR's. Since we now use `nyc` directly, and pass the the `--no-cov` flag in our `tap` commands, this is no longer a problem.

Does not yet handle missing `package.json`

This implements the `--no-cache` flag, but in this commit it's always set. I want to see how well `--no-cache` works on Windows...

I need to decide on a good testing strategy for this.

I have updated it to use `write-file-atomic` to avoid race conditions

jamestalmage · 2015-12-24T11:44:24Z

OK, This is ready for review.

// @vdemedes @sindresorhus

sindresorhus · 2015-12-24T13:20:20Z

cli.js

@@ -77,7 +78,8 @@ if (cli.flags.tap) {
 var api = new Api(cli.input, {
 	failFast: cli.flags.failFast,
 	serial: cli.flags.serial,
-	require: arrify(cli.flags.require)
+	require: arrify(cli.flags.require),
+	noCache: cli.flags.cache === false


noCache => cache. I don't like double negatives.

sindresorhus · 2015-12-24T13:24:01Z

lib/caching-precompiler.js

+		.update(code, 'utf8')
+		.update(filename || 'unknown file', 'utf8')
+		.update(salt || '', 'utf8')
+		.digest('hex');


This could use https://github.com/sindresorhus/md5-hex now.

jamestalmage · 2015-12-30T07:30:33Z

closed in favor of #390

jamestalmage force-pushed the move-babel-to-main-thread branch 3 times, most recently from 09c8308 to 2ba0686 Compare December 22, 2015 10:29

sindresorhus force-pushed the master branch from 9c32200 to 52d2a7a Compare December 22, 2015 12:38

jamestalmage mentioned this pull request Dec 22, 2015

Performance issues after Babel 6 upgrade #351

Closed

jamestalmage force-pushed the move-babel-to-main-thread branch 2 times, most recently from 60c0cbf to c738c78 Compare December 22, 2015 19:07

sindresorhus reviewed Dec 22, 2015
View reviewed changes

jamestalmage force-pushed the move-babel-to-main-thread branch from 235e320 to 21a98a4 Compare December 22, 2015 19:48

jamestalmage mentioned this pull request Dec 23, 2015

Make --require relative to where the command is run. #346

Closed

jamestalmage added 8 commits December 22, 2015 21:28

move babel to main thread

5a66e9d

There are many failing tests, but it basically works.

WIP - fix tests. one still skipped. not the prettiest solution either

5507a7d

add caching

9abb688

use rimraf so pretest is cross-platform

0d88ba8

don't re-require babel plugins every time buildOptions is called.

07f27e4

swap rimraf for del-cli

4970e6b

jamestalmage force-pushed the move-babel-to-main-thread branch from 9c7072e to 4970e6b Compare December 23, 2015 02:29

remove unnecessary nyc config

be4497f

jamestalmage added 11 commits December 22, 2015 21:32

rename assign -> objectAssign to match dependency name.

748acf4

delete pointless test

4db22da

remove unused dependencies

54a8051

compute best location for .cache dir.

ef4730f

Does not yet handle missing `package.json`

test-transformer -> caching-precompiler

6c8f11d

move cacheDir logic to caching-precompiler

c710b64

add --no-cache CLI flag (squash this - always true)

ca00ce9

This implements the `--no-cache` flag, but in this commit it's always set. I want to see how well `--no-cache` works on Windows...

actually enable --no-cache (squash with above).

9c893e8

I need to decide on a good testing strategy for this.

use classic reporter in test-win

d6a8f7a

salt the hash

32df154

bump caching-transform

a3174cf

I have updated it to use `write-file-atomic` to avoid race conditions

jamestalmage changed the title ~~[WIP] Move Babel transforms to the main process.~~ Move Babel transforms to the main process. Dec 24, 2015

fix npm@2: append ava's node_modules directory to _nodeModulePaths()

e80f8d3

sindresorhus reviewed Dec 24, 2015
View reviewed changes

jamestalmage mentioned this pull request Dec 24, 2015

allow array argument sindresorhus/md5-hex#2

Merged

sindresorhus reviewed Dec 24, 2015
View reviewed changes

jamestalmage added 3 commits December 24, 2015 08:36

use md5hex now that is supports arrays of values.

200d194

noCache -> cache

fc48e56

bump caching-precompiler to 1.0.0, and strip-bom sources.

ca9f7a4

jamestalmage mentioned this pull request Dec 27, 2015

Forking for every test file is slow #78

Closed

jamestalmage mentioned this pull request Dec 30, 2015

Transpile in main thread #390

Merged

sindresorhus closed this Dec 30, 2015

jamestalmage deleted the move-babel-to-main-thread branch April 6, 2016 22:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move Babel transforms to the main process. #349

Move Babel transforms to the main process. #349

jamestalmage commented Dec 22, 2015

vadimdemedes commented Dec 22, 2015

jamestalmage commented Dec 22, 2015

sindresorhus Dec 22, 2015

jamestalmage Dec 22, 2015

sindresorhus Dec 22, 2015

jamestalmage commented Dec 22, 2015

jamestalmage commented Dec 22, 2015

sindresorhus commented Dec 22, 2015

jamestalmage commented Dec 22, 2015

jamestalmage commented Dec 24, 2015

sindresorhus Dec 24, 2015

sindresorhus Dec 24, 2015

jamestalmage commented Dec 30, 2015

Move Babel transforms to the main process. #349

Move Babel transforms to the main process. #349

Conversation

jamestalmage commented Dec 22, 2015

vadimdemedes commented Dec 22, 2015

jamestalmage commented Dec 22, 2015

sindresorhus Dec 22, 2015

Choose a reason for hiding this comment

jamestalmage Dec 22, 2015

Choose a reason for hiding this comment

sindresorhus Dec 22, 2015

Choose a reason for hiding this comment

jamestalmage commented Dec 22, 2015

jamestalmage commented Dec 22, 2015

sindresorhus commented Dec 22, 2015

jamestalmage commented Dec 22, 2015

jamestalmage commented Dec 24, 2015

sindresorhus Dec 24, 2015

Choose a reason for hiding this comment

sindresorhus Dec 24, 2015

Choose a reason for hiding this comment

jamestalmage commented Dec 30, 2015