fix: add support for use of arrays in t.like #3023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the PR @Gozala! I think this could work, but it's been a while since I've thought about the logic here. It'll definitely need tests, I think the existing ones are in test-tap/assert.js.
| return selector !== null | ||
| && typeof selector === 'object' | ||
| && Reflect.getPrototypeOf(selector) === Object.prototype | ||
| && (prototype === Object.prototype || prototype === Array.prototype) |
There was a problem hiding this comment.
I think this could use Array.isArray(selector). Note that Reflect.ownKeys() on an array returns length which messes up the next condition.
|
Hi @Gozala, do you think you would have time to get back to this? |
I'm afraid not. I end up switching off of ava as it would not run in browser contexts. If I get back to using ava I'll definitely make some time for this. |
|
No problem, thanks! |
tommy-mitchell
pushed a commit
to tommy-mitchell/ava
that referenced
this pull request
Mar 13, 2023
tommy-mitchell
added a commit
to tommy-mitchell/ava
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2627