WIP: Format failed external asserts nicer #2230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External asserts like: - chai - expect Closes avajs#1277
novemberborn
reviewed
Sep 1, 2019
Yeah! Judging by a quick look, they usually have an already formatted |
Sounds great! |
novemberborn
requested changes
Sep 15, 2019
There was a problem hiding this comment.
@tryzniak could you add some tests for this? Let me know if you'd like some pointers.
|
Closing due to inactivity. We'd be happy to pick this up again when you have the time to get back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. This for #1277 . I'd love to show you what I've been up to, here are the new output
testfile
I don't really like the way
supertesterrors are shown, I have no idea how we could detect what line of the test its expect failed.Other errors have inconsistent formatting, which is not very nice.
I'm thinking of capturing and detecting a type of an error earlier.
Any input would be useful for me! Thanks