Clean up caching precompiler #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimdemedes
force-pushed
the
cleanup-caching-precompiler
branch
from
1086536 to
075c4c8
Compare
novemberborn
requested changes
Oct 15, 2016
| var avaPackage = require.resolve('../package.json'); | ||
|
|
||
| var packages = [avaPackage].concat(pluginPackages); | ||
| var packageSalt = JSON.stringify(this.babelConfig); |
There was a problem hiding this comment.
You need to add process.version.split('.')[0] to this. Note that it's currently broken: https://github.com/avajs/ava/pull/1068/files#r83534244.
vadimdemedes
force-pushed
the
cleanup-caching-precompiler
branch
from
075c4c8 to
9e1cc96
Compare
novemberborn
approved these changes
Oct 16, 2016
sindresorhus
approved these changes
Oct 17, 2016
|
Nice cleanup @vdemedes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny clean up of
lib/caching-precompiler.js.Changes:
_factorymethod, which was a bit confusing (at least to me).