Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Add Static File support #73

Merged
merged 17 commits into from
Nov 25, 2024
Merged

Re-Add Static File support #73

merged 17 commits into from
Nov 25, 2024

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Nov 25, 2024

Adds support for creating handlers that serve static resources.

  • Adds a StaticContentConfig class that will construct a handler to serve files
  • Adds three static handlers. one for regular files, jars and another for more esoteric cases like when using jlink
  • Re-add some Basic HttpResponse Exceptions (we don't need as many as we had before, but catching framework errors is pretty useful)

@SentryMan SentryMan added the enhancement New feature or request label Nov 25, 2024
@SentryMan SentryMan added this to the 3.0 milestone Nov 25, 2024
@SentryMan SentryMan self-assigned this Nov 25, 2024
@SentryMan
Copy link
Collaborator Author

hmm, it would seem that it doesn't properly load when running a modular jar outside of jlink

@SentryMan SentryMan marked this pull request as draft November 25, 2024 07:03
auto-merge was automatically disabled November 25, 2024 07:03

Pull request was converted to draft

@SentryMan SentryMan marked this pull request as ready for review November 25, 2024 20:28
@SentryMan SentryMan enabled auto-merge (squash) November 25, 2024 20:28
@SentryMan
Copy link
Collaborator Author

@rbygrave please review when you find time

@SentryMan SentryMan merged commit e14efa5 into avaje:master Nov 25, 2024
4 checks passed
@SentryMan SentryMan deleted the static-files branch November 25, 2024 22:10
@SentryMan
Copy link
Collaborator Author

I think we should be good for an RC so I can try this stuff out for real. Unless you have some other ideas for features?

@rbygrave
Copy link
Contributor

good for an RC

Yeah cool. I'll roll one out when I get home.

I will look to add a separate helper module to avaje-jex to support htmx features (to match the htmx support we have for nima/helidon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants