Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename isAddBeanFor to isBeanAbsent #727

Merged
merged 9 commits into from
Nov 20, 2024
Merged

Rename isAddBeanFor to isBeanAbsent #727

merged 9 commits into from
Nov 20, 2024

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Nov 2, 2024 •
edited
Loading

I feel this rolls off the tongue a little better.

  • deprecated the old methods for removal in 11
  • change generation to use the new name

@SentryMan SentryMan added this to the 10.5 milestone Nov 2, 2024
@SentryMan SentryMan self-assigned this Nov 2, 2024
@rbygrave
Copy link
Contributor

rbygrave commented Nov 4, 2024

Hmmm, isBeanAbsent is kind of ok but also kind of misleading [when parentOverride is true].

@SentryMan SentryMan changed the title Rename isAddBeanFor to isBeanAbsent Rename isAddBeanFor to canRegister Nov 4, 2024
@SentryMan
Copy link
Collaborator Author

how about canRegister?

@SentryMan
Copy link
Collaborator Author

10.5 is looking pretty stacked, this can probably be the last feature to add

@rbygrave
Copy link
Contributor

rbygrave commented Nov 5, 2024 •
edited
Loading

I don't think canRegister() is an improvement. I'd say isBeanAbsent was better than canRegister. I'm just not sure about isBeanAbsent yet. At this stage I don't think this makes it into 10.5.

@SentryMan
Revert "canRegister"
75f014d 
This reverts commit 6bf246e.
@SentryMan SentryMan changed the title Rename isAddBeanFor to canRegister Rename isAddBeanFor to isBeanAbsent Nov 5, 2024
@SentryMan SentryMan removed this from the 10.5 milestone Nov 5, 2024
@rbygrave rbygrave added this to the 10.6 milestone Nov 20, 2024
@SentryMan SentryMan merged commit d1e1e40 into avaje:master Nov 20, 2024
7 checks passed
@SentryMan SentryMan deleted the isbeanAbsent branch November 20, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave rbygrave approved these changes

Assignees

@SentryMan SentryMan

Labels
refactor
Projects
None yet
Milestone
10.6
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rbygrave