Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exports limitation from Module Path Detection #720

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

SentryMan
Copy link
Collaborator

Removes the main weakness of #718 by reading the provides directives of all external modules.

@SentryMan SentryMan added the enhancement New feature or request label Oct 31, 2024
@SentryMan SentryMan added this to the 10.5 milestone Oct 31, 2024
@SentryMan SentryMan self-assigned this Oct 31, 2024
@SentryMan
Copy link
Collaborator Author

SentryMan commented Oct 31, 2024

ok in this situation we need to export the org.example.external.aspect.sub package because some classes are used in the tests. But if you look at a failure log of a previous run where we did not have the package exported, you will see that it compiled successfully and failed only on test compilation

@SentryMan SentryMan disabled auto-merge October 31, 2024 04:05
@SentryMan SentryMan enabled auto-merge (squash) October 31, 2024 04:06
@SentryMan SentryMan merged commit 74aec7b into avaje:master Oct 31, 2024
7 checks passed
@SentryMan SentryMan deleted the enhance-module-detection branch October 31, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants