Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Events into their own module #600

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Split Events into their own module #600

merged 8 commits into from
Jun 10, 2024

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jun 10, 2024 •
edited
Loading

  • changes event package to events
  • moves everything into its own module and adds as a transitive dep to inject
  • changes generation to directly register an Observer

@SentryMan SentryMan requested a review from rbygrave June 10, 2024 02:54
@SentryMan SentryMan self-assigned this Jun 10, 2024
@SentryMan SentryMan added this to the 10.0 milestone Jun 10, 2024
rbygrave
rbygrave reviewed Jun 10, 2024
View reviewed changes
inject-events/pom.xml
<dependency>
<groupId>io.avaje</groupId>
<artifactId>avaje-inject</artifactId>
<version>10.0-RC5</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to check this after merge, probably should be RC6 and not RC5 here.

@rbygrave rbygrave merged commit 476a036 into avaje:master Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave rbygrave approved these changes

Assignees

@SentryMan SentryMan

Labels
refactor
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rbygrave