-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a switch to determine multi-module wiring order at compile time. #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbygrave
changed the title
Add a switch to determine wiring order at compile time.
Add a switch to determine module wiring order at compile time.
Jan 9, 2024
SentryMan
force-pushed
the
wiring-order
branch
from
January 27, 2024 16:29
aac63db
to
c9584a3
Compare
SentryMan
force-pushed
the
wiring-order
branch
from
February 29, 2024 01:35
c53f233
to
4687e91
Compare
for the strict wiring path there is no need to initialize
SentryMan
changed the title
Add a switch to determine module wiring order at compile time.
Add a switch to determine multi-module wiring order at compile time.
Apr 7, 2024
I've broken something with my last commits there trying to resolve the merge conflict. Not sure if we want to remove/revert those ones and try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the thought here is that we can directly read the
requires
andprovides
via the external provider and determine the wiring order in the generator.Then we can generate a class like this:
which knows ahead of time what goes where.
should fix #478