Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aspect Auto Requires #271

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Add Aspect Auto Requires #271

merged 4 commits into from
Feb 1, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jan 31, 2023

Now modules can automatically provide aspects for use in other modules without directly exposing the underlying aspect target.

  • Modifies the ExternalProvider to read the autoProvidesAspects from loaded modules
  • adds autoRequiresAspects to Module Class
  • updates DBeanScopeBuilder to read the autoRequiresAspects and use it for module ordering.

Fixes #269 (nice)

Now that I consider it, do we even need the target field in the @Aspect annotation anymore?

@rbygrave
Copy link
Contributor

rbygrave commented Feb 1, 2023

Note: These commits have been included in #270

@rbygrave rbygrave added this to the 8.12 milestone Feb 1, 2023
@rbygrave rbygrave merged commit 77f5859 into avaje:master Feb 1, 2023
@SentryMan SentryMan deleted the aspectRequires branch February 1, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoProvideAspects doesn't work as expected
2 participants