Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static inner classes as dependencies #180

Closed
doppelrittberger opened this issue Dec 22, 2021 · 2 comments
Closed

Static inner classes as dependencies #180

doppelrittberger opened this issue Dec 22, 2021 · 2 comments
Assignees
@doppelrittberger
Labels
bug Something isn't working
Milestone
6.20

Comments

@doppelrittberger
Copy link

doppelrittberger commented Dec 22, 2021 •
edited
Loading

Hi,

if I use static inner classes as bean definitions Avaje seems to struggle. It creates a package which is named like the parent class and this package clashes with the parent class itself.

public class MyBeans {
@Singleton
public static class Bean1 {}
}

Above example generates a class in package MyBeans and this name clashes with the name of the class MyBeans.

If a PR is ok please let me know.

Thanks
Markus
@rbygrave
Copy link
Contributor

Yes, a PR would be great !!

doppelrittberger pushed a commit to doppelrittberger/avaje-inject that referenced this issue Dec 23, 2021
added fix and test for avaje#180
3dfb16b
doppelrittberger pushed a commit to doppelrittberger/avaje-inject that referenced this issue Dec 23, 2021
added fix and test for avaje#180
6348748 
(cherry picked from commit 3dfb16b)
@doppelrittberger doppelrittberger mentioned this issue Dec 23, 2021
Closed
doppelrittberger pushed a commit to doppelrittberger/avaje-inject that referenced this issue Dec 23, 2021
added fix and test for avaje#180
7ee4b7b
@rbygrave rbygrave added the bug Something isn't working label Dec 23, 2021
@rbygrave rbygrave linked a pull request Dec 23, 2021 that will close this issue
added fix and test for #180 #182
Closed
@rbygrave rbygrave added this to the 6.20 milestone Dec 23, 2021
@rbygrave
Copy link
Contributor

Fix PR merged into master, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doppelrittberger doppelrittberger

Labels
bug Something isn't working
Projects
None yet
Milestone
6.20
Development

Successfully merging a pull request may close this issue.

added fix and test for #180 doppelrittberger/avaje-inject
2 participants
@rbygrave @doppelrittberger