Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Feature generation #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feature generation #3

wants to merge 5 commits into from

Conversation

Iceman-bfw
Copy link
Contributor

Implemented new structure to Flow-Py:

  • seperated GUI from main.py and PyQt imports are only done if needed
  • changed flow_core.py to only have one calculation function, and let the infrastructure part optional if infra_bool is True
  • in flow_core.py: implemented a generation list, as a parent of the cell_list. cell_list now has only the cells of the current generation, stores them after calculation in gen_list as list.
  • in flow_class.py: erased the mass_distribution part, didn't worked how expected and actually no need for it

@pep8speaks
Copy link

Hello @Iceman-bfw! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 199:80: E501 line too long (178 > 79 characters)

Line 88:1: W293 blank line contains whitespace
Line 97:80: E501 line too long (85 > 79 characters)
Line 108:1: W293 blank line contains whitespace
Line 115:8: E111 indentation is not a multiple of four
Line 115:80: E501 line too long (85 > 79 characters)
Line 115:86: W291 trailing whitespace
Line 130:80: E501 line too long (89 > 79 characters)
Line 131:1: W293 blank line contains whitespace
Line 138:53: E261 at least two spaces before inline comment
Line 146:1: W293 blank line contains whitespace
Line 166:33: E261 at least two spaces before inline comment
Line 166:80: E501 line too long (113 > 79 characters)
Line 167:80: E501 line too long (134 > 79 characters)
Line 167:104: E261 at least two spaces before inline comment
Line 172:1: W293 blank line contains whitespace
Line 173:80: E501 line too long (92 > 79 characters)
Line 176:80: E501 line too long (95 > 79 characters)
Line 189:80: E501 line too long (94 > 79 characters)
Line 192:80: E501 line too long (97 > 79 characters)
Line 206:80: E501 line too long (99 > 79 characters)
Line 210:80: E501 line too long (142 > 79 characters)
Line 212:36: W291 trailing whitespace
Line 213:39: W291 trailing whitespace
Line 216:1: W293 blank line contains whitespace
Line 217:35: E261 at least two spaces before inline comment
Line 219:80: E501 line too long (124 > 79 characters)
Line 220:80: E501 line too long (104 > 79 characters)
Line 224:80: E501 line too long (124 > 79 characters)
Line 225:80: E501 line too long (88 > 79 characters)
Line 226:80: E501 line too long (124 > 79 characters)
Line 227:80: E501 line too long (87 > 79 characters)
Line 229:13: E265 block comment should start with '# '
Line 232:21: E265 block comment should start with '# '
Line 236:80: E501 line too long (128 > 79 characters)
Line 236:129: W291 trailing whitespace
Line 237:80: E501 line too long (115 > 79 characters)
Line 241:76: W291 trailing whitespace
Line 245:1: W293 blank line contains whitespace
Line 254:80: E501 line too long (93 > 79 characters)
Line 259:25: W291 trailing whitespace

Line 46:1: W293 blank line contains whitespace
Line 47:37: W291 trailing whitespace
Line 51:1: W293 blank line contains whitespace
Line 63:9: E265 block comment should start with '# '
Line 64:9: E265 block comment should start with '# '
Line 83:1: W293 blank line contains whitespace
Line 87:1: W293 blank line contains whitespace
Line 107:1: W293 blank line contains whitespace
Line 113:1: W293 blank line contains whitespace
Line 118:13: E265 block comment should start with '# '
Line 119:1: W293 blank line contains whitespace
Line 126:80: E501 line too long (82 > 79 characters)
Line 131:1: W293 blank line contains whitespace
Line 135:13: E722 do not use bare 'except'
Line 137:1: W293 blank line contains whitespace
Line 140:13: E722 do not use bare 'except'
Line 142:1: W293 blank line contains whitespace
Line 145:13: E722 do not use bare 'except'
Line 147:1: W293 blank line contains whitespace
Line 150:13: E722 do not use bare 'except'
Line 152:1: W293 blank line contains whitespace
Line 155:13: E722 do not use bare 'except'
Line 163:80: E501 line too long (84 > 79 characters)
Line 164:59: E127 continuation line over-indented for visual indent
Line 165:59: E127 continuation line over-indented for visual indent
Line 165:80: E501 line too long (83 > 79 characters)
Line 174:80: E501 line too long (94 > 79 characters)
Line 183:80: E501 line too long (98 > 79 characters)
Line 190:80: E501 line too long (84 > 79 characters)
Line 192:80: E501 line too long (96 > 79 characters)
Line 206:80: E501 line too long (109 > 79 characters)
Line 207:80: E501 line too long (86 > 79 characters)
Line 210:80: E501 line too long (87 > 79 characters)
Line 240:80: E501 line too long (86 > 79 characters)
Line 244:1: W293 blank line contains whitespace
Line 253:13: E116 unexpected indentation (comment)
Line 261:80: E501 line too long (104 > 79 characters)
Line 276:80: E501 line too long (85 > 79 characters)
Line 277:80: E501 line too long (84 > 79 characters)
Line 284:80: E501 line too long (101 > 79 characters)
Line 293:80: E501 line too long (101 > 79 characters)
Line 296:80: E501 line too long (93 > 79 characters)
Line 301:9: E722 do not use bare 'except'
Line 305:1: W293 blank line contains whitespace
Line 309:1: W293 blank line contains whitespace
Line 312:33: E261 at least two spaces before inline comment
Line 313:1: W293 blank line contains whitespace
Line 315:1: W293 blank line contains whitespace
Line 316:80: E501 line too long (92 > 79 characters)
Line 317:80: E501 line too long (110 > 79 characters)
Line 319:80: E501 line too long (100 > 79 characters)
Line 320:1: W293 blank line contains whitespace
Line 327:1: W293 blank line contains whitespace
Line 340:1: W293 blank line contains whitespace
Line 343:68: W291 trailing whitespace
Line 344:80: E501 line too long (82 > 79 characters)
Line 349:80: E501 line too long (86 > 79 characters)
Line 369:80: E501 line too long (106 > 79 characters)
Line 372:80: E501 line too long (109 > 79 characters)
Line 375:80: E501 line too long (117 > 79 characters)
Line 378:80: E501 line too long (117 > 79 characters)
Line 382:80: E501 line too long (117 > 79 characters)
Line 385:80: E501 line too long (117 > 79 characters)
Line 389:80: E501 line too long (121 > 79 characters)
Line 394:80: E501 line too long (81 > 79 characters)
Line 397:1: W293 blank line contains whitespace
Line 398:1: E305 expected 2 blank lines after class or function definition, found 1
Line 399:19: W292 no newline at end of file

Line 39:24: W291 trailing whitespace
Line 222:24: W291 trailing whitespace
Line 234:80: E501 line too long (144 > 79 characters)
Line 235:80: E501 line too long (197 > 79 characters)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants