Merge pull request #6 from rclarkburns/legacy

Adds JsonSerializable interface workaround Thanks for making these changes! I'm going to close out your issue #5 with this merge.
avadev · Jul 15, 2014 · 1dfd191 · 1dfd191
2 parents 24e5991 + 6f08cd3
commit 1dfd191
Show file tree

Hide file tree

Showing 10 changed files with 31 additions and 17 deletions.
diff --git a/AvaTaxClasses/classes/BaseResult.class.php b/AvaTaxClasses/classes/BaseResult.class.php
@@ -16,11 +16,11 @@ class BaseResult implements JsonSerializable
 {
 
 	public function jsonSerialize(){
-		return [
+		return array(
 			'TransactionId' => $this->getTransactionId(),
 			'ResultCode' => $this->getResultCode(),
 			'Messages' => $this->getMessages()
-		];
+		);
 	}
 
 /**

diff --git a/AvaTaxClasses/classes/CancelTaxResult.class.php b/AvaTaxClasses/classes/CancelTaxResult.class.php
@@ -50,12 +50,12 @@ public function parseResult($jsonString)
 	}
 
 	public function jsonSerialize(){
-		return [
+		return array(
 			'DocId' => $this->getDocId(),
 			'TransactionId' => $this->getTransactionId(),
 			'ResultCode' => $this->getResultCode(),
 			'Messages' => $this->getMessages()
-		];
+		);
 	}
 
 	public function getDocId() { return $this->DocId; }

diff --git a/AvaTaxClasses/classes/EstimateTaxResult.class.php b/AvaTaxClasses/classes/EstimateTaxResult.class.php
@@ -47,13 +47,13 @@ public static function parseResult($jsonString)
 	}
 
 	public function jsonSerialize(){
-		return[
+		return array(
 			'Rate' => $this->getRate(),
 			'Tax' => $this->getTax(),
 			'TaxDetails' => $this->getTaxDetails(),
 			'ResultCode' => $this->getResultCode(),
 			'Messages' => $this->getMessages()
-		];
+		);
 	}
 
 /**

diff --git a/AvaTaxClasses/classes/GetTaxResult.class.php b/AvaTaxClasses/classes/GetTaxResult.class.php
@@ -99,7 +99,7 @@ public static function parseResult($jsonString)
 	}
 
 	public function jsonSerialize(){
-		return[
+		return array(
 			'DocCode' =>  $this->getDocCode(), 
 			'DocDate' =>  $this->getDocDate(),			 				
 			'Timestamp' =>  $this->getTimestamp(),			
@@ -115,7 +115,7 @@ public function jsonSerialize(){
 			'TaxAddresses' =>  $this->getTaxAddresses(),
 			'ResultCode'=> $this->getResultCode(),
 			'Messages' => $this->getMessages()
-		];
+		);
 	}
 
 	public function getDocCode() { return $this->DocCode; } 

diff --git a/AvaTaxClasses/classes/JsonSerializable.class.php b/AvaTaxClasses/classes/JsonSerializable.class.php
@@ -0,0 +1,13 @@
+<?php
+/**
+ * Created by PhpStorm.
+ * User: clark
+ * Date: 7/14/14
+ * Time: 12:44 PM
+ */
+
+interface JsonSerializable {
+
+	public function jsonSerialize();
+
+}
diff --git a/AvaTaxClasses/classes/Message.class.php b/AvaTaxClasses/classes/Message.class.php
@@ -62,13 +62,13 @@ public function parseMessages($jsonString)
 
 	}
 	public function jsonSerialize(){
-		return[
+		return array(
 			'Summary' => $this->getSummary(),
 			'Details' => $this->getDetails(),
 			'RefersTo' => $this->getRefersTo(),
 			'Severity' => $this->getSeverity(),
 			'Source' => $this->getSource(),
-		];
+		);
 	}
 
 	public function getSummary() { return $this->Summary; }

diff --git a/AvaTaxClasses/classes/TaxDetail.class.php b/AvaTaxClasses/classes/TaxDetail.class.php
@@ -79,7 +79,7 @@ public function parseTaxDetails($jsonString)
 			return $detailArray;
 		}
 	public function jsonSerialize(){
-		return[
+		return array(
 		 'JurisType' => $this->getJurisType(),
 		 'Taxable' => $this->getTaxable(),
 		 'Rate' => $this->getRate(),
@@ -88,7 +88,7 @@ public function jsonSerialize(){
 		 'TaxName' => $this->getTaxName(),
 		 'Country' => $this->getCountry(),
 		 'Region' => $this->getRegion()
-		];
+		);
 	}
 
 	 public function getJurisType(){ return $this->JurisType; } 

diff --git a/AvaTaxClasses/classes/TaxLine.class.php b/AvaTaxClasses/classes/TaxLine.class.php
@@ -82,7 +82,7 @@ public static function parseTaxLines($jsonString)
 		return $lineArray;
 	}
 	public function jsonSerialize(){
-		return[
+		return array(
 			'TaxDetails' => $this->getTaxDetails(),
 			'LineNo' => $this->getLineNo(),
 			'TaxCode' => $this->getTaxCode(),
@@ -94,7 +94,7 @@ public function jsonSerialize(){
 			'Rate' => $this->getRate(),
 			'Tax' => $this->getTax(),
 			'TaxCalculated' => $this->getTaxCalculated()
-		];
+		);
 	}
 
 	public function getTaxDetails() { return $this->TaxDetails; }

diff --git a/AvaTaxClasses/classes/ValidateResult.class.php b/AvaTaxClasses/classes/ValidateResult.class.php
@@ -65,11 +65,11 @@ public static function parseResult($jsonString)
 		return new self( $resultcode , $validaddress , $messages );	
 	}
 	public function jsonSerialize(){
-		return[
+		return array(
 			'ValidAddress' => $this->getValidAddress(),
 			'ResultCode' => $this->getResultCode(),
 			'Messages' => $this->getMessages()
-		];
+		);
 	}
 
 	public function getValidAddress() { return $this->ValidAddress; }

diff --git a/README.md b/README.md
@@ -26,7 +26,8 @@ Contents:
 
 Dependencies:
 -----------
-- PHP 5.0 or later
+- PHP 5.3 or later
+- Not tested on versions older than PHP 5.3
 
 Requirements:
 ----------