Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.0.18: add support for protocol version 28 #200

Merged
merged 5 commits into from
Sep 18, 2023
Merged

0.0.18: add support for protocol version 28 #200

merged 5 commits into from
Sep 18, 2023

Conversation

hexfusion
Copy link
Contributor

No description provided.

Copy link
Collaborator

@richardpringle richardpringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@@ -11,7 +11,7 @@ repository = "https://github.com/ava-labs/timestampvm-rs"
readme = "../README.md"

[dependencies]
avalanche-types = { version = "0.0.399", features = ["subnet", "codec_base64"] } # https://crates.io/crates/avalanche-types
avalanche-types = { version = "0.1.2", features = ["subnet", "codec_base64"] } # https://crates.io/crates/avalanche-types
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hexfusion
Copy link
Contributor Author

need to update avalanchego

Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Copy link
Contributor Author

hexfusion commented Sep 18, 2023

[node3] [09-18|15:24:10.082] ERROR chains/manager.go:357 error creating chain {"subnetID": "p433wpuXyJiDhyazPYyZMJeaoPSW76CBZ2x7wrVPLgvokotXz", "chainID": "2Cb7MNGNSivZGrjXFVwCbLPJnfQB5bwiqk5HaD5U8LZ37oh3dE", "chainAlias": "2Cb7MNGNSivZGrjXFVwCbLPJnfQB5bwiqk5HaD5U8LZ37oh3dE", "vmID": "tGas3T58KzdjcJ2iKSyiYsWiqYctRXaPTqBCA11BqEkNg8kPc", "error": "error while creating new snowman vm rpc error: code = Unimplemented desc = verify_height_index"}

@exdx
Copy link
Contributor

exdx commented Sep 18, 2023

I pushed the missing methods but the ChainVM interface is updated only in the next avalanche-types release.

Basically waiting to merge ava-labs/avalanche-rs#49 and cut a new release and then CI will be green.

Signed-off-by: Dan Sover <[email protected]>
@hexfusion hexfusion merged commit 0c5c84d into main Sep 18, 2023
@hexfusion hexfusion deleted the pv28 branch September 18, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants