-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chain] Address Refactor #571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
commented
Oct 18, 2023
patrick-ogrady
added this to the
v0.0.16 (Improvements from Devnet Experiments) milestone
Nov 9, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #267
Resolves: #603
Blocks: #378
The HyperSDK is tightly bound to
crypto.ed25519
. This PR explicitly integratescrypto.secp256r1
to force us to come up with a more generic abstractions (codec.Address
). This is required for anyone adding custom cryptography and for upcoming HyperSDK Program integration.TODO
utils
toaddress
auth
toaddress
NewED25519Address
toaddress
and make it work forsecp256r1
tokenvm
compilationuse home directory for CLI defaultChangeShortBytes()
toAddress()
(explain prefix is used to properly extract value from bech32 encoding)ids.ID
for all addresses (makes entirely uniform for spending) -> anything can receive balances/pay fees?Auth
defined as WASM here.Actor
to Auth interface explicitlyREADME
Address
description to README (mention bytes are always 32 byte hash, which prevents someone from knowing publicKey until spend)codec.AddressBytes
->codec.Address
MorpheusVM
README