-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chain] Warm Key Path #549
Conversation
@@ -10,6 +10,10 @@ import ( | |||
"github.com/ava-labs/avalanchego/x/merkledb" | |||
) | |||
|
|||
type Base interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: better name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "Prefetcher"?
Prefetch time can vary quite a bit by key:
|
Best guess for slowdown...frequently updating cache is causing contention with prefetch or tons of extra memory allocations? |
17b22bf
to
3c1014d
Compare
This PR has become stale because it has been open for 30 days with no activity. Adding the |
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Prefetch cache optimization was reverted here: https://github.com/ava-labs/avalanchego/pull/2576/files |
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Closes: #491
Blocked by: ava-labs/avalanchego#2167
We wait for 64 keys to be updated and then trigger a path prefetch async.
TODO