Move action and auth registry to registry package
#1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #1257 to get in to update |
aaronbuchwald
previously approved these changes
Aug 8, 2024
aaronbuchwald
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1219
This PR solves the issue in a different way than it has been presented. Moving the initialization function to the
constspackage isn't working very well because it imports fromaction, andactionimportsconstswhich creates a cyclic dependency.ActionRegistryandAuthRegistryare not really constants, so it's not terribly wrong for them to be moved out of theconstspackage. Since they are now initialized in the same package they are defined, it removes the need of this weird anonymous import.