Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Silence remaining InvalidDefaultArgInFrom warnings #3684

Merged
merged 1 commit into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
LICENSE
*.md

Dockerfile

# Ignore all dockerfiles not just the main one
Dockerfile*
2 changes: 1 addition & 1 deletion tests/antithesis/avalanchego/Dockerfile.workload
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
ARG BUILDER_IMAGE_TAG=INVALID # This value isn't intended to be used but silences a warning

# AVALANCHEGO_NODE_IMAGE needs to identify an existing node image and should include the tag
ARG AVALANCHEGO_NODE_IMAGE=INVALID # This value isn't intended to be used but silences a warning
ARG AVALANCHEGO_NODE_IMAGE="invalid-image" # This value isn't intended to be used but silences a warning

# ============= Compilation Stage ================
FROM antithesis-avalanchego-builder:$BUILDER_IMAGE_TAG AS builder
Expand Down
2 changes: 1 addition & 1 deletion tests/antithesis/xsvm/Dockerfile.node
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
ARG BUILDER_IMAGE_TAG=INVALID # This value isn't intended to be used but silences a warning

# AVALANCHEGO_NODE_IMAGE needs to identify an existing avalanchego node image and should include the tag
ARG AVALANCHEGO_NODE_IMAGE=INVALID # This value isn't intended to be used but silences a warning
ARG AVALANCHEGO_NODE_IMAGE="invalid-image" # This value isn't intended to be used but silences a warning

# ============= Compilation Stage ================
FROM antithesis-avalanchego-builder:$BUILDER_IMAGE_TAG AS builder
Expand Down
2 changes: 1 addition & 1 deletion tests/antithesis/xsvm/Dockerfile.workload
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
ARG BUILDER_IMAGE_TAG=INVALID # This value isn't intended to be used but silences a warning

# AVALANCHEGO_NODE_IMAGE needs to identify an existing node image and should include the tag
ARG AVALANCHEGO_NODE_IMAGE=INVALID # This value isn't intended to be used but silences a warning
ARG AVALANCHEGO_NODE_IMAGE="invalid-image" # This value isn't intended to be used but silences a warning

# ============= Compilation Stage ================
FROM antithesis-avalanchego-builder:$BUILDER_IMAGE_TAG AS builder
Expand Down
Loading